Skip to content

Commit 360c539

Browse files
committed
Make dataset tests parallelizable
1 parent c6ca16f commit 360c539

File tree

2 files changed

+19
-17
lines changed

2 files changed

+19
-17
lines changed

tests/integration/test_dataset.py

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -7,27 +7,19 @@
77

88

99
def test_dataset(client, rand_gen):
10-
before = list(client.get_datasets())
11-
for o in before:
12-
assert isinstance(o, Dataset)
1310

11+
# confirm dataset can be created
1412
name = rand_gen(str)
1513
dataset = client.create_dataset(name=name)
1614
assert dataset.name == name
1715
assert dataset.created_by() == client.get_user()
1816
assert dataset.organization() == client.get_organization()
1917

20-
after = list(client.get_datasets())
21-
assert len(after) == len(before) + 1
22-
assert dataset in after
23-
24-
# confirm get_one returns first dataset
25-
get_one_dataset = client.get_datasets().get_one()
26-
assert get_one_dataset.uid == after[0].uid
27-
28-
# confirm get_many(1) returns first dataset
29-
get_many_datasets = client.get_datasets().get_many(1)
30-
assert get_many_datasets[0].uid == after[0].uid
18+
retrieved_dataset = client.get_dataset(dataset.uid)
19+
assert retrieved_dataset.name == dataset.name
20+
assert retrieved_dataset.uid == dataset.uid
21+
assert retrieved_dataset.created_by() == dataset.created_by()
22+
assert retrieved_dataset.organization() == dataset.organization()
3123

3224
dataset = client.get_dataset(dataset.uid)
3325
assert dataset.name == name
@@ -48,9 +40,6 @@ def test_dataset(client, rand_gen):
4840
assert dataset.description == description
4941

5042
dataset.delete()
51-
final = list(client.get_datasets())
52-
assert dataset not in final
53-
assert set(final) == set(before)
5443

5544
with pytest.raises(ResourceNotFoundError):
5645
dataset = client.get_dataset(dataset.uid)
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
from copy import copy
2+
3+
4+
def test_get_one_and_many_dataset_order(client):
5+
paginator = client.get_datasets()
6+
# confirm get_one returns first dataset
7+
all_datasets = list(paginator)
8+
get_one_dataset = copy(paginator).get_one()
9+
assert get_one_dataset.uid == all_datasets[0].uid
10+
11+
# confirm get_many(1) returns first dataset
12+
get_many_datasets = copy(paginator).get_many(1)
13+
assert get_many_datasets[0].uid == all_datasets[0].uid

0 commit comments

Comments
 (0)