Skip to content

Commit 23c9d6e

Browse files
authored
Merge pull request #626 from Labelbox/ms/unassign-split
support unassigned splits
2 parents 00b5351 + d4589bd commit 23c9d6e

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

labelbox/schema/model_run.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -203,13 +203,7 @@ def assign_data_rows_to_split(self,
203203
timeout_seconds=120):
204204

205205
split_value = split.value if isinstance(split, DataSplit) else split
206-
207-
if split_value == DataSplit.UNASSIGNED.value:
208-
raise ValueError(
209-
f"Cannot assign split value of `{DataSplit.UNASSIGNED.value}`.")
210-
211-
valid_splits = filter(lambda name: name != DataSplit.UNASSIGNED.value,
212-
DataSplit._member_names_)
206+
valid_splits = DataSplit._member_names_
213207

214208
if split_value not in valid_splits:
215209
raise ValueError(

tests/integration/annotation_import/test_model_run.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -146,13 +146,7 @@ def test_model_run_split_assignment(model_run, dataset, image_url):
146146
with pytest.raises(ValueError):
147147
model_run.assign_data_rows_to_split(data_row_ids, "INVALID SPLIT")
148148

149-
with pytest.raises(ValueError):
150-
model_run.assign_data_rows_to_split(data_row_ids, DataSplit.UNASSIGNED)
151-
152-
for split in ["TRAINING", "TEST", "VALIDATION", *DataSplit]:
153-
if split == DataSplit.UNASSIGNED:
154-
continue
155-
149+
for split in ["TRAINING", "TEST", "VALIDATION", "UNASSIGNED", *DataSplit]:
156150
model_run.assign_data_rows_to_split(data_row_ids, split)
157151
counts = Counter()
158152
for data_row in model_run.model_run_data_rows():

0 commit comments

Comments
 (0)