Merge pull request #847 from Labelbox/sdubinin/al-000-fix-confidence

[AL-000] Fixed confidence for TextEntity

Author: dubininsergey

labelbox/data/serialization/ndjson/objects.py

@@ -352,11 +352,14 @@ def to_common(self) -> TextEntity:
         return TextEntity(start=self.location.start, end=self.location.end)
 
     @classmethod
-    def from_common(cls, text_entity: TextEntity,
-                    classifications: List[ClassificationAnnotation], name: str,
-                    feature_schema_id: Cuid, extra: Dict[str, Any],
-                    data: Union[ImageData,
-                                TextData], confidence: float) -> "NDTextEntity":
+    def from_common(cls,
+                    text_entity: TextEntity,
+                    classifications: List[ClassificationAnnotation],
+                    name: str,
+                    feature_schema_id: Cuid,
+                    extra: Dict[str, Any],
+                    data: Union[ImageData, TextData],
+                    confidence: Optional[float] = None) -> "NDTextEntity":
         return cls(location=Location(
             start=text_entity.start,
             end=text_entity.end,

tests/data/serialization/ndjson/test_text_entity.py

@@ -10,7 +10,7 @@
     "tests/data/assets/ndjson/text_entity_without_confidence_import.json"
 ])
 def test_text_entity_import(filename: str):
-    with open('tests/data/assets/ndjson/text_entity_import.json', 'r') as file:
+    with open(filename, 'r') as file:
         data = json.load(file)
     res = NDJsonConverter.deserialize(data).as_list()
     res = list(NDJsonConverter.serialize(res))