Skip to content

Commit 179f184

Browse files
committed
add todo note for consideration
1 parent 0f516be commit 179f184

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

labelbox/client.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1048,7 +1048,12 @@ def get_data_row_ids_for_global_keys(self,
10481048
get_job_params)
10491049

10501050
get_data_rows_str = """query getDataRowsForGlobalKeysPyApi($jobId: ID!) {
1051-
dataRowsForGlobalKeysResult(jobId: {id: $jobId}) { data { fetchedDataRows {id}} jobStatus}}
1051+
dataRowsForGlobalKeysResult(jobId: {id: $jobId}) { data {
1052+
fetchedDataRows {id}
1053+
notFoundGlobalKeys
1054+
accessDeniedGlobalKeys
1055+
deletedDataRowGlobalKeys
1056+
} jobStatus}}
10521057
"""
10531058
get_data_rows_params = {
10541059
"jobId":
@@ -1058,6 +1063,7 @@ def get_data_row_ids_for_global_keys(self,
10581063
while timeout >= 0:
10591064
res = self.execute(get_data_rows_str, get_data_rows_params)
10601065
if res["dataRowsForGlobalKeysResult"]['jobStatus'] == "COMPLETE":
1066+
# TODO: should consider deleted, not found, global keys return?
10611067
return res["dataRowsForGlobalKeysResult"]['data'][
10621068
'fetchedDataRows']
10631069
time.sleep(2)

0 commit comments

Comments
 (0)