PR feedback

Move tests for free text annotation to its separate file

Author: Val Brodsky

tests/data/serialization/ndjson/test_free_text.py

@@ -0,0 +1,103 @@
+from labelbox.data.annotation_types.annotation import ClassificationAnnotation
+from labelbox.data.annotation_types.classification.classification import Checklist, ClassificationAnswer, Radio, Text
+from labelbox.data.annotation_types.data.text import TextData
+from labelbox.data.annotation_types.label import Label
+
+from labelbox.data.serialization.ndjson.converter import NDJsonConverter
+
+
+def test_serialization():
+    label = Label(uid="ckj7z2q0b0000jx6x0q2q7q0d",
+                  data=TextData(
+                      uid="bkj7z2q0b0000jx6x0q2q7q0d",
+                      text="This is a test",
+                  ),
+                  annotations=[
+                      ClassificationAnnotation(name="free_text_annotation",
+                                               value=Text(confidence=0.5,
+                                                          answer="text_answer"))
+                  ])
+
+    serialized = NDJsonConverter.serialize([label])
+    res = next(serialized)
+
+    assert res['confidence'] == 0.5
+    assert res['name'] == "free_text_annotation"
+    assert res['answer'] == "text_answer"
+    assert res['dataRow']['id'] == "bkj7z2q0b0000jx6x0q2q7q0d"
+
+    deserialized = NDJsonConverter.deserialize([res])
+    res = next(deserialized)
+
+    annotation = res.annotations[0]
+
+    annotation_value = annotation.value
+    assert type(annotation_value) is Text
+    assert annotation_value.answer == "text_answer"
+    assert annotation_value.confidence == 0.5
+
+
+def test_nested_serialization():
+    label = Label(
+        uid="ckj7z2q0b0000jx6x0q2q7q0d",
+        data=TextData(
+            uid="bkj7z2q0b0000jx6x0q2q7q0d",
+            text="This is a test",
+        ),
+        annotations=[
+            ClassificationAnnotation(
+                name="nested test",
+                value=Checklist(answer=[
+                    ClassificationAnswer(
+                        name="first_answer",
+                        confidence=0.9,
+                        classifications=[
+                            ClassificationAnnotation(
+                                name="sub_radio_question",
+                                value=Radio(answer=ClassificationAnswer(
+                                    name="first_sub_radio_answer",
+                                    confidence=0.8,
+                                    classifications=[
+                                        ClassificationAnnotation(
+                                            name="nested answer",
+                                            value=Text(
+                                                answer="nested answer",
+                                                confidence=0.7,
+                                            ))
+                                    ])))
+                        ])
+                ]),
+            )
+        ])
+
+    serialized = NDJsonConverter.serialize([label])
+    res = next(serialized)
+
+    assert res['dataRow']['id'] == "bkj7z2q0b0000jx6x0q2q7q0d"
+    answer = res['answer'][0]
+    assert answer['confidence'] == 0.9
+    assert answer['name'] == "first_answer"
+    classification = answer['classifications'][0]
+    nested_classification_answer = classification['answer']
+    assert nested_classification_answer['confidence'] == 0.8
+    assert nested_classification_answer['name'] == "first_sub_radio_answer"
+    sub_classification = nested_classification_answer['classifications'][0]
+    assert sub_classification['name'] == "nested answer"
+    assert sub_classification['answer'] == "nested answer"
+    assert sub_classification['confidence'] == 0.7
+
+    deserialized = NDJsonConverter.deserialize([res])
+    res = next(deserialized)
+    annotation = res.annotations[0]
+    answer = annotation.value.answer[0]
+    assert answer.confidence == 0.9
+    assert answer.name == "first_answer"
+
+    classification_answer = answer.classifications[0].value.answer
+    assert classification_answer.confidence == 0.8
+    assert classification_answer.name == "first_sub_radio_answer"
+
+    sub_classification_answer = classification_answer.classifications[0].value
+    assert type(sub_classification_answer) is Text
+    assert sub_classification_answer.answer == "nested answer"
+    assert sub_classification_answer.confidence == 0.7

tests/data/serialization/ndjson/test_text.py

@@ -1,5 +1,5 @@
 from labelbox.data.annotation_types.annotation import ClassificationAnnotation
-from labelbox.data.annotation_types.classification.classification import Checklist, ClassificationAnswer, Radio, Text
+from labelbox.data.annotation_types.classification.classification import ClassificationAnswer, Radio, Text
 from labelbox.data.annotation_types.data.text import TextData
 from labelbox.data.annotation_types.label import Label
 
@@ -13,92 +13,23 @@ def test_serialization():
                       text="This is a test",
                   ),
                   annotations=[
-                      ClassificationAnnotation(name="free_text_annotation",
-                                               value=Text(confidence=0.5,
-                                                          answer="text_answer"))
+                      ClassificationAnnotation(
+                          name="radio_question_geo",
+                          confidence=0.5,
+                          value=Text(answer="first_radio_answer"))
                   ])
 
     serialized = NDJsonConverter.serialize([label])
     res = next(serialized)
-
-    assert res['confidence'] == 0.5
-    assert res['name'] == "free_text_annotation"
-    assert res['answer'] == "text_answer"
+    assert 'confidence' not in res  # because confidence needs to be set on the annotation itself
+    assert res['name'] == "radio_question_geo"
+    assert res['answer'] == "first_radio_answer"
     assert res['dataRow']['id'] == "bkj7z2q0b0000jx6x0q2q7q0d"
 
     deserialized = NDJsonConverter.deserialize([res])
     res = next(deserialized)
-
     annotation = res.annotations[0]
-    answer = annotation.value.answer
 
     annotation_value = annotation.value
     assert type(annotation_value) is Text
-    assert annotation_value.answer == "text_answer"
-    assert annotation_value.confidence == 0.5
-
-
-def test_nested_serialization():
-    label = Label(
-        uid="ckj7z2q0b0000jx6x0q2q7q0d",
-        data=TextData(
-            uid="bkj7z2q0b0000jx6x0q2q7q0d",
-            text="This is a test",
-        ),
-        annotations=[
-            ClassificationAnnotation(
-                name="nested test",
-                value=Checklist(answer=[
-                    ClassificationAnswer(
-                        name="first_answer",
-                        confidence=0.9,
-                        classifications=[
-                            ClassificationAnnotation(
-                                name="sub_radio_question",
-                                value=Radio(answer=ClassificationAnswer(
-                                    name="first_sub_radio_answer",
-                                    confidence=0.8,
-                                    classifications=[
-                                        ClassificationAnnotation(
-                                            name="nested answer",
-                                            value=Text(
-                                                answer="nested answer",
-                                                confidence=0.7,
-                                            ))
-                                    ])))
-                        ])
-                ]),
-            )
-        ])
-
-    serialized = NDJsonConverter.serialize([label])
-    res = next(serialized)
-
-    assert res['dataRow']['id'] == "bkj7z2q0b0000jx6x0q2q7q0d"
-    answer = res['answer'][0]
-    assert answer['confidence'] == 0.9
-    assert answer['name'] == "first_answer"
-    classification = answer['classifications'][0]
-    nested_classification_answer = classification['answer']
-    assert nested_classification_answer['confidence'] == 0.8
-    assert nested_classification_answer['name'] == "first_sub_radio_answer"
-    sub_classification = nested_classification_answer['classifications'][0]
-    assert sub_classification['name'] == "nested answer"
-    assert sub_classification['answer'] == "nested answer"
-    assert sub_classification['confidence'] == 0.7
-
-    deserialized = NDJsonConverter.deserialize([res])
-    res = next(deserialized)
-    annotation = res.annotations[0]
-    answer = annotation.value.answer[0]
-    assert answer.confidence == 0.9
-    assert answer.name == "first_answer"
-
-    classification_answer = answer.classifications[0].value.answer
-    assert classification_answer.confidence == 0.8
-    assert classification_answer.name == "first_sub_radio_answer"
-
-    sub_classification_answer = classification_answer.classifications[0].value
-    assert type(sub_classification_answer) is Text
-    assert sub_classification_answer.answer == "nested answer"
-    assert sub_classification_answer.confidence == 0.7
+    assert annotation_value.answer == "first_radio_answer"