Skip to content

Commit 0dfb3f4

Browse files
authored
Merge pull request #730 from Labelbox/eg/fixing-tests
Fixing data row import tests
2 parents 226944a + df5b4e4 commit 0dfb3f4

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tests/integration/test_data_rows.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ def test_create_data_rows_with_invalid_metadata(dataset, image_url):
352352
DataRow.metadata_fields: fields
353353
}])
354354
task.wait_till_done()
355-
assert task.status == "COMPLETE"
355+
assert task.status == "FAILED"
356356
assert len(task.failed_data_rows) > 0
357357

358358

@@ -633,9 +633,10 @@ def test_data_row_bulk_creation_with_same_global_keys(dataset, sample_image):
633633
}])
634634

635635
task.wait_till_done()
636-
assert task.status == "COMPLETE"
636+
assert task.status == "FAILED"
637637
assert len(task.failed_data_rows) > 0
638638
assert len(list(dataset.data_rows())) == 0
639+
assert task.errors == "Import job failed"
639640

640641
task = dataset.create_data_rows([{
641642
DataRow.row_data: sample_image,

tests/integration/test_task.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import pytest
22

3-
from labelbox import DataRow, Task
3+
from labelbox import DataRow
44
from labelbox.schema.data_row_metadata import DataRowMetadataField
55

66
EMBEDDING_SCHEMA_ID = "ckpyije740000yxdk81pbgjdc"
@@ -21,13 +21,12 @@ def test_task_errors(dataset, image_url):
2121
]
2222
},
2323
])
24+
2425
assert task in client.get_user().created_tasks()
2526
task.wait_till_done()
26-
assert task.status == "COMPLETE"
27+
assert task.status == "FAILED"
2728
assert len(task.failed_data_rows) > 0
2829
assert task.errors is not None
29-
assert 'message' in task.errors[0]
30-
assert len(task.result) == 0
3130

3231

3332
def test_task_success_json(dataset, image_url):

0 commit comments

Comments
 (0)