Skip to content

Commit 0c7be25

Browse files
author
Val Brodsky
committed
PR Get rid of camelcase
1 parent cde2f2a commit 0c7be25

File tree

6 files changed

+22
-20
lines changed

6 files changed

+22
-20
lines changed

labelbox/data/annotation_types/ner/document_entity.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,12 @@
22

33
from pydantic import BaseModel, validator
44

5+
from labelbox.utils import _CamelCaseMixin
56

6-
class DocumentTextSelection(BaseModel):
7-
tokenIds: List[str]
8-
groupId: str
7+
8+
class DocumentTextSelection(_CamelCaseMixin, BaseModel):
9+
token_ids: List[str]
10+
group_id: str
911
page: int
1012

1113
@validator("page")
@@ -15,7 +17,7 @@ def validate_page(cls, v):
1517
return v
1618

1719

18-
class DocumentEntity(BaseModel):
20+
class DocumentEntity(_CamelCaseMixin, BaseModel):
1921
""" Represents a text entity """
2022
name: str
21-
textSelections: List[DocumentTextSelection]
23+
text_selections: List[DocumentTextSelection]

labelbox/data/serialization/ndjson/objects.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -374,10 +374,10 @@ def from_common(cls,
374374

375375
class NDDocumentEntity(NDBaseObject, ConfidenceMixin):
376376
name: str
377-
textSelections: List[DocumentTextSelection]
377+
text_selections: List[DocumentTextSelection]
378378

379379
def to_common(self) -> DocumentEntity:
380-
return TextEntity(name=self.name, textSelections=self.textSelections)
380+
return TextEntity(name=self.name, text_selections=self.text_selections)
381381

382382
return obj.from_common(annotation.value, subclasses, annotation.name,
383383
annotation.feature_schema_id, annotation.extra,
@@ -393,7 +393,7 @@ def from_common(cls,
393393
data: Union[ImageData, TextData],
394394
confidence: Optional[float] = None) -> "NDDocumentEntity":
395395

396-
return cls(textSelections=document_entity.textSelections,
396+
return cls(text_selections=document_entity.text_selections,
397397
dataRow=DataRow(id=data.uid),
398398
name=name,
399399
schema_id=feature_schema_id,

tests/data/annotation_types/test_ner.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ def test_ner():
1111

1212
def test_document_entity():
1313
document_entity = DocumentEntity(name="tool_name",
14-
textSelections=[
14+
text_selections=[
1515
DocumentTextSelection(
16-
tokenIds=["1", "2"],
17-
groupId="1",
16+
token_ids=["1", "2"],
17+
group_id="1",
1818
page=1)
1919
])
2020

2121
assert document_entity.name == "tool_name"
22-
assert document_entity.textSelections[0].tokenIds == ["1", "2"]
23-
assert document_entity.textSelections[0].groupId == "1"
24-
assert document_entity.textSelections[0].page == 1
22+
assert document_entity.text_selections[0].token_ids == ["1", "2"]
23+
assert document_entity.text_selections[0].group_id == "1"
24+
assert document_entity.text_selections[0].page == 1

tests/integration/annotation_import/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,10 +168,10 @@ def configured_project_pdf(client, ontology, rand_gen, pdf_url):
168168

169169

170170
@pytest.fixture
171-
def dataset_pdf_entity(client, rand_gen, pdf_entity_row_data):
171+
def dataset_pdf_entity(client, rand_gen, pdf_entity_data_row):
172172
dataset = client.create_dataset(name=rand_gen(str))
173173
data_row_ids = []
174-
data_row = dataset.create_data_row(pdf_entity_row_data)
174+
data_row = dataset.create_data_row(pdf_entity_data_row)
175175
data_row_ids.append(data_row.uid)
176176
yield dataset, data_row_ids
177177
dataset.delete()

tests/integration/annotation_import/test_bulk_import_request.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,8 @@ def test_pdf_document_entity(client, configured_project_without_data_rows,
297297
dataset_pdf_entity, rand_gen):
298298
# for content "Metal-insulator (MI) transitions have been one of the" in OCR JSON extract tests/assets/arxiv-pdf_data_99-word-token-pdfs_0801.3483-lb-textlayer.json
299299
document_text_selection = DocumentTextSelection(
300-
groupId="2f4336f4-a07e-4e0a-a9e1-5629b03b719b",
301-
tokenIds=[
300+
group_id="2f4336f4-a07e-4e0a-a9e1-5629b03b719b",
301+
token_ids=[
302302
"3f984bf3-1d61-44f5-b59a-9658a2e3440f",
303303
"3bf00b56-ff12-4e52-8cc1-08dbddb3c3b8",
304304
"6e1c3420-d4b7-4c5a-8fd6-ead43bf73d80",
@@ -311,7 +311,7 @@ def test_pdf_document_entity(client, configured_project_without_data_rows,
311311
page=1)
312312

313313
entities_annotation_document_entity = DocumentEntity(
314-
name="named_entity", textSelections=[document_text_selection])
314+
name="named_entity", text_selections=[document_text_selection])
315315
entities_annotation = ObjectAnnotation(
316316
name="named-entity", value=entities_annotation_document_entity)
317317

tests/integration/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ def pdf_url(client):
178178

179179

180180
@pytest.fixture(scope="session")
181-
def pdf_entity_row_data(client):
181+
def pdf_entity_data_row(client):
182182
pdf_url = client.upload_file(
183183
'tests/assets/arxiv-pdf_data_99-word-token-pdfs_0801.3483.pdf')
184184
text_layer_url = client.upload_file(

0 commit comments

Comments
 (0)