Skip to content

Commit 0a58293

Browse files
committed
Removed version, type + corrected externalId from bulk convo upload.
1 parent 0877ac3 commit 0a58293

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

labelbox/schema/dataset.py

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ def check_message_keys(message):
294294
for key in message.keys():
295295
if not key in accepted_message_keys:
296296
raise KeyError(
297-
f"Invalid {key} key found! Accepted keys in messages list is ")
297+
f"Invalid {key} key found! Accepted keys in messages list is {accepted_message_keys}")
298298

299299
if conversational_data and not isinstance(conversational_data, list):
300300
raise ValueError(
@@ -348,19 +348,22 @@ def convert_item(item):
348348

349349
if "conversationalData" in item:
350350
messages = item.pop("conversationalData")
351+
version = item.pop("version")
352+
type = item.pop("type")
353+
if "externalId" in item:
354+
external_id = item.pop("externalId")
355+
item["external_id"] = external_id
351356
validate_conversational_data(messages)
352-
validate_attachments(item)
353357
one_conversation = \
354-
{
355-
"type": item["type"],
356-
"version": item["version"],
357-
"messages": messages
358-
}
358+
{
359+
"type": type,
360+
"version": version,
361+
"messages": messages
362+
}
359363
conversationUrl = self.client.upload_data(json.dumps(one_conversation),
360364
content_type="application/json",
361365
filename="conversational_data.json")
362-
item["conversationalUrl"] = conversationUrl
363-
return item
366+
item["row_data"] = conversationUrl
364367

365368
# Convert all payload variations into the same dict format
366369
item = format_row(item)

0 commit comments

Comments
 (0)