Merge pull request #882 from LIT-Protocol/feature/jss-86-bugnaga-fix-webauthn-cbor-issue-due-to-missing-pub-key

[Bug] fix(webauthn): to include scopes in the API

Author: Ansonhkg

packages/auth-services/src/auth-server/src/routes/pkp/mint.ts

@@ -2,12 +2,12 @@ import { ElysiaInstance } from '../../types/ElysiaInstance.type';
 import { addJob } from '../../../../queue-manager/src/bullmqSetup';
 import { resp } from '../../response-helpers/response-helpers';
 import { mintPkpDoc } from '../../../../queue-manager/src/handlers/pkpMint/pkpMint.doc';
-import { AuthServiceMintRequestRaw } from '../../schemas/AuthServiceMintRequestSchema';
+import { MintPKPRequest } from '@lit-protocol/schemas';
 
 export const mint = (app: ElysiaInstance) => {
   app.post(
     '/mint',
-    async ({ body }: { body: AuthServiceMintRequestRaw }) => {
+    async ({ body }: { body: MintPKPRequest }) => {
       try {
         const job = await addJob('pkpMint', { requestBody: body });
         return resp.QUEUED(job.id, 'PKP minting request queued successfully.');

packages/auth-services/src/auth-server/src/schemas/AuthServiceMintRequestSchema.ts

@@ -1,30 +1,28 @@
-import { AuthData } from '@lit-protocol/schemas';
+import {
+  AuthData,
+  MintPKPRequest,
+  MintPKPRequestSchema,
+} from '@lit-protocol/schemas';
 import { Optional } from '@lit-protocol/types';
-import { Hex } from 'viem';
 
 /**
  * Handles PKP minting tasks.
  * @param jobData The data for the job, expected to contain `requestBody`.
  * @returns The result of the PKP minting process.
  */
 export async function handlePkpMintTask(jobData: {
-  requestBody: {
-    authMethodType: string;
-    authMethodId: Hex;
-    pubkey: Hex;
-    scopes?: ('sign-anything' | 'personal-sign' | 'no-permissions')[];
-  };
+  requestBody: MintPKPRequest;
+  reqId?: string;
 }): Promise<any> {
-  const userAuthData: Optional<AuthData, 'accessToken'> = {
-    authMethodId: jobData.requestBody.authMethodId,
-    authMethodType: Number(jobData.requestBody.authMethodType),
-    publicKey: jobData.requestBody.pubkey,
-  };
 
   const result = await globalThis.systemContext.litClient.mintWithAuth({
     account: globalThis.systemContext.account,
-    authData: userAuthData,
-    scopes: jobData.requestBody.scopes || [],
+    authData: {
+      authMethodId: jobData.requestBody.authMethodId,
+      authMethodType: jobData.requestBody.authMethodType,
+      publicKey: jobData.requestBody.pubkey,
+    },
+    scopes: jobData.requestBody.scopes,
   });
 
   console.log(

packages/auth-services/src/queue-manager/src/handlers/pkpMint/pkpMint.handler.ts

@@ -14,12 +14,13 @@ import {
 } from '@lit-protocol/constants';
 import { AuthMethod, AuthServerTx, Hex } from '@lit-protocol/types';
 
-import { AuthData, PKPData } from '@lit-protocol/schemas';
+import { AuthData, PKPData, ScopeStringSchema } from '@lit-protocol/schemas';
 import { getRPIdFromOrigin, parseAuthenticatorData } from '../helper/utils';
 
 import { EthBlockhashInfo } from '@lit-protocol/types';
 import { pollResponse } from '../helper/pollResponse';
 import { JobStatusResponse } from '../types';
+import { z } from 'zod';
 
 const fetchBlockchainData = async () => {
   try {
@@ -149,6 +150,7 @@ export class WebAuthnAuthenticator {
   public static async registerAndMintPKP(params: {
     username?: string;
     authServiceBaseUrl: string;
+    scopes?: z.infer<typeof ScopeStringSchema>[];
   }): Promise<{
     pkpInfo: PKPData;
 
@@ -183,6 +185,7 @@ export class WebAuthnAuthenticator {
       authMethodType: AUTH_METHOD_TYPE.WebAuthn,
       authMethodId: authMethodId,
       pubkey: authMethodPubkey,
+      scopes: params.scopes,
     };
 
     // Immediate mint a new PKP to associate with the auth method

packages/auth/src/lib/authenticators/native/WebAuthnAuthenticator.ts

@@ -358,7 +358,8 @@ export const _createNagaLitClient = async (
     return await networkModule.api.signCustomSessionKey.handleResponse(
       result as any,
       params.requestBody.pkpPublicKey,
-      jitContext
+      jitContext,
+      requestId
     );
   }
 

packages/lit-client/src/lib/LitClient/createLitClient.ts

@@ -1,4 +1,4 @@
-import { AuthData } from '@lit-protocol/schemas';
+import { AuthData, CustomAuthDataSchema } from '@lit-protocol/schemas';
 import { Optional } from '@lit-protocol/types';
 import { z } from 'zod';
 
@@ -9,7 +9,7 @@ const BaseMintWithCustomAuthSchema = z.object({
   // Account information - this will be passed from the calling context
   account: z.any(), // Account type varies by network
   // Authentication data for the user
-  authData: z.custom<Optional<AuthData, 'accessToken'>>(),
+  authData: CustomAuthDataSchema,
   scope: z.enum(['no-permissions', 'sign-anything', 'personal-sign']),
   // Optional overrides
   addPkpEthAddressAsPermittedAddress: z.boolean().default(false),

packages/lit-client/src/lib/LitClient/schemas/MintWithCustomAuthSchema.ts

@@ -1,3 +1,4 @@
+import { CustomAuthData, CustomAuthDataSchema } from '@lit-protocol/schemas';
 import { hexToBigInt, keccak256, toBytes } from 'viem';
 
 export const utils = {
@@ -56,12 +57,14 @@ export const utils = {
     uniqueDappName: string;
     uniqueAuthMethodType: bigint;
     userId: string;
-  }) => {
+  }): CustomAuthData => {
     const uniqueUserId = `${uniqueDappName}-${userId}`;
 
-    return {
+    const customAuthData = CustomAuthDataSchema.parse({
       authMethodType: uniqueAuthMethodType,
       authMethodId: keccak256(toBytes(uniqueUserId)),
-    };
+    });
+
+    return customAuthData;
   },
 };

packages/lit-client/src/lib/LitClient/utils.ts

@@ -2,12 +2,14 @@ import { DEV_PRIVATE_KEY, version } from '@lit-protocol/constants';
 import { verifyAndDecryptWithSignatureShares } from '@lit-protocol/crypto';
 import {
   AuthData,
+  AuthDataInput,
   EncryptedVersion1Schema,
   GenericEncryptedPayloadSchema,
   GenericResultBuilder,
   HexPrefixedSchema,
   JsonSignCustomSessionKeyRequestForPkpReturnSchema,
   JsonSignSessionKeyRequestForPkpReturnSchema,
+  ScopeStringSchema,
 } from '@lit-protocol/schemas';
 import { Hex, hexToBytes, stringToBytes, bytesToHex } from 'viem';
 import { z } from 'zod';
@@ -377,8 +379,8 @@ export function createBaseModule<T, M>(config: BaseModuleConfig<T, M>) {
 
       mintWithAuth: async (params: {
         account: ExpectedAccountOrWalletClient;
-        authData: Optional<AuthData, 'accessToken'>;
-        scopes: ('sign-anything' | 'personal-sign' | 'no-permissions')[];
+        authData: Optional<AuthDataInput, 'accessToken'>;
+        scopes: z.infer<typeof ScopeStringSchema>[];
       }): Promise<GenericTxRes<LitTxRes<PKPData>, PKPData>> => {
         const chainManager = createChainManager(params.account);
         const res = await chainManager.api.mintPKP({

packages/networks/src/networks/vNaga/shared/factories/BaseModuleFactory.ts

@@ -57,7 +57,7 @@ import type { PKPStorageProvider } from '../../../../../../../../storage/types';
 import { logger } from '../../../../../../../shared/logger';
 import { DefaultNetworkConfig } from '../../../../../../shared/interfaces/NetworkContext';
 import { ExpectedAccountOrWalletClient } from '../../../../contract-manager/createContractsManager';
-import { ScopeString } from '../../../schemas/shared/ScopeSchema';
+import { ScopeString } from '@lit-protocol/schemas';
 import { AuthMethod } from '../../rawContractApis/permissions/read/getPermittedAuthMethods';
 import { LitTxVoid } from '../../types';
 

packages/networks/src/networks/vNaga/shared/managers/LitChainClient/apis/highLevelApis/PKPPermissionsManager/PKPPermissionsManager.ts

@@ -1,7 +1,7 @@
 import { DefaultNetworkConfig } from '../../../../../../../shared/interfaces/NetworkContext';
 import { isIpfsCidV0 } from '../../../../../../../../shared/utils/z-validate';
 import { z } from 'zod';
-import { ScopeStringSchema } from '../../../../schemas/shared/ScopeSchema';
+import { ScopeStringSchema } from '@lit-protocol/schemas';
 import {
   PkpIdentifierRaw,
   resolvePkpTokenId,