Migrate from BCV to abiValidation (#4487)

* Remove obsolete asm dependency that BCV relied on

Author: qwwdfsad

build.gradle.kts

@@ -23,7 +23,6 @@ buildscript {
         classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:${version("kotlin")}")
         classpath("org.jetbrains.dokka:dokka-gradle-plugin:${version("dokka")}")
         classpath("org.jetbrains.kotlinx:kotlinx-knit:${version("knit")}")
-        classpath("org.jetbrains.kotlinx:binary-compatibility-validator:${version("binary_compatibility_validator")}")
         classpath("ru.vyarus:gradle-animalsniffer-plugin:${version("animalsniffer")}") // Android API check
         classpath("org.jetbrains.kotlin:atomicfu:${version("kotlin")}")
         classpath("org.jetbrains.kotlinx:kover-gradle-plugin:${version("kover")}")
@@ -62,21 +61,9 @@ allprojects {
     }
 }
 
-plugins {
-    id("org.jetbrains.kotlinx.binary-compatibility-validator") version "0.16.2"
-}
-
 apply(plugin = "base")
 apply(plugin = "kover-conventions")
 
-apiValidation {
-    ignoredProjects += unpublished + listOf("kotlinx-coroutines-bom")
-    @OptIn(kotlinx.validation.ExperimentalBCVApi::class)
-    klib {
-        enabled = true
-    }
-}
-
 // Configure repositories
 allprojects {
     repositories {

buildSrc/build.gradle.kts

@@ -61,8 +61,7 @@ dependencies {
         exclude(group = "org.jetbrains.kotlin", module = "kotlin-stdlib-jdk7")
         exclude(group = "org.jetbrains.kotlin", module = "kotlin-stdlib")
     }
-    // Force ASM version, otherwise the one from animalsniffer wins (which is too low for BCV)
-    implementation("org.ow2.asm:asm:9.6")
+
     implementation("ru.vyarus:gradle-animalsniffer-plugin:${version("animalsniffer")}") // Android API check
     implementation("org.jetbrains.kotlinx:kover-gradle-plugin:${version("kover")}") {
         exclude(group = "org.jetbrains.kotlin", module = "kotlin-stdlib-jdk8")

buildSrc/src/main/kotlin/Projects.kt

@@ -37,6 +37,8 @@ val unpublished = setOf("kotlinx.coroutines", "benchmarks", "android-unit-tests"
 val Project.isMultiplatform: Boolean get() = name in setOf(coreModule, "kotlinx-coroutines-test", testUtilsModule)
 val Project.isBom: Boolean get() = name == "kotlinx-coroutines-bom"
 
+val Project.abiCheckEnabled get() = name !in unpublished + "kotlinx-coroutines-bom"
+
 // Projects that we do not check for Android API level 14 check due to various limitations
 val androidNonCompatibleProjects = setOf(
     "kotlinx-coroutines-debug",

buildSrc/src/main/kotlin/kotlin-jvm-conventions.gradle.kts

@@ -2,6 +2,7 @@
 
 import org.gradle.api.*
 import org.jetbrains.kotlin.gradle.dsl.*
+import org.jetbrains.kotlin.gradle.dsl.abi.ExperimentalAbiValidation
 
 plugins {
     kotlin("jvm")
@@ -13,6 +14,11 @@ java {
 }
 
 kotlin {
+    @OptIn(ExperimentalAbiValidation::class)
+    abiValidation {
+        enabled = abiCheckEnabled
+    }
+
     compilerOptions {
         jvmTarget = JvmTarget.JVM_1_8
         configureGlobalKotlinArgumentsAndOptIns()
@@ -37,3 +43,7 @@ tasks.withType<Test> {
     val stressTest = project.properties["stressTest"]
     if (stressTest != null) systemProperties["stressTest"] = stressTest
 }
+
+tasks.check {
+   dependsOn(tasks.checkLegacyAbi)
+}

buildSrc/src/main/kotlin/kotlin-multiplatform-conventions.gradle.kts

@@ -1,5 +1,6 @@
 import org.gradle.api.tasks.testing.logging.*
 import org.jetbrains.kotlin.gradle.dsl.*
+import org.jetbrains.kotlin.gradle.dsl.abi.ExperimentalAbiValidation
 
 plugins {
     kotlin("multiplatform")
@@ -11,6 +12,15 @@ java {
 }
 
 kotlin {
+    @OptIn(ExperimentalAbiValidation::class)
+    abiValidation {
+        enabled = abiCheckEnabled
+
+        klib {
+            enabled = true
+        }
+    }
+
     jvm {
         compilations.all {
             compileTaskProvider.configure {
@@ -150,3 +160,7 @@ tasks.named("jvmTest", Test::class) {
     }
     project.properties["stressTest"]?.let { systemProperty("stressTest", it) }
 }
+
+tasks.check {
+   dependsOn(tasks.checkLegacyAbi)
+}

gradle.properties

@@ -26,7 +26,6 @@ rxjava2_version=2.2.8
 rxjava3_version=3.0.2
 javafx_version=17.0.2
 javafx_plugin_version=0.0.8
-binary_compatibility_validator_version=0.16.2
 kover_version=0.8.0-Beta2
 blockhound_version=1.0.8.RELEASE
 jna_version=5.9.0