Restore allWarningsAsErrors in main source-sets (#4336)

Author: qwwdfsad

buildSrc/src/main/kotlin/configure-compilation-conventions.gradle.kts

@@ -16,9 +16,9 @@ configure(subprojects) {
                 apiVersion = it
                 versionsAreNotOverridden = false
             }
-            if (isMainTaskName && versionsAreNotOverridden && !unpublished.contains(project.name)) {
+            if (isMainTaskName && !unpublished.contains(project.name)) {
                 allWarningsAsErrors = true
-                freeCompilerArgs.add("-Xexplicit-api=strict")
+                freeCompilerArgs.addAll("-Xexplicit-api=strict", "-Xdont-warn-on-error-suppression")
             }
             /* Coroutines do not interop with Java and these flags provide a significant
              * (i.e. close to double-digit) reduction in both bytecode and optimized dex size */

gradle.properties

@@ -2,7 +2,6 @@
 version=1.10.1-SNAPSHOT
 group=org.jetbrains.kotlinx
 kotlin_version=2.1.0
-kotlin_language_version=2.1
 # DO NOT rename this property without adapting kotlinx.train build chain:
 atomicfu_version=0.26.1
 

kotlinx-coroutines-core/common/src/Builders.common.kt

@@ -1,6 +1,7 @@
 @file:JvmMultifileClass
 @file:JvmName("BuildersKt")
 @file:OptIn(ExperimentalContracts::class)
+@file:Suppress("LEAKED_IN_PLACE_LAMBDA", "WRONG_INVOCATION_KIND")
 
 package kotlinx.coroutines
 
@@ -153,7 +154,6 @@ public suspend fun <T> withContext(
         // FAST PATH #1 -- new context is the same as the old one
         if (newContext === oldContext) {
             val coroutine = ScopeCoroutine(newContext, uCont)
-            @Suppress("LEAKED_IN_PLACE_LAMBDA") // Contract is preserved, invoked immediately or throws
             return@sc coroutine.startUndispatchedOrReturn(coroutine, block)
         }
         // FAST PATH #2 -- the new dispatcher is the same as the old one (something else changed)
@@ -162,13 +162,11 @@ public suspend fun <T> withContext(
             val coroutine = UndispatchedCoroutine(newContext, uCont)
             // There are changes in the context, so this thread needs to be updated
             withCoroutineContext(coroutine.context, null) {
-                @Suppress("LEAKED_IN_PLACE_LAMBDA") // Contract is preserved, invoked immediately or throws
                 return@sc coroutine.startUndispatchedOrReturn(coroutine, block)
             }
         }
         // SLOW PATH -- use new dispatcher
         val coroutine = DispatchedCoroutine(newContext, uCont)
-        @Suppress("LEAKED_IN_PLACE_LAMBDA")  // Contract is preserved, invoked immediately or throws
         block.startCoroutineCancellable(coroutine, coroutine)
         coroutine.getResult()
     }

kotlinx-coroutines-core/common/src/CoroutineScope.kt

@@ -1,4 +1,5 @@
 @file:OptIn(ExperimentalContracts::class)
+@file:Suppress("LEAKED_IN_PLACE_LAMBDA", "WRONG_INVOCATION_KIND")
 
 package kotlinx.coroutines
 
@@ -281,7 +282,6 @@ public suspend fun <R> coroutineScope(block: suspend CoroutineScope.() -> R): R
     }
     return suspendCoroutineUninterceptedOrReturn { uCont ->
         val coroutine = ScopeCoroutine(uCont.context, uCont)
-        @Suppress("LEAKED_IN_PLACE_LAMBDA") // Contract is preserved, invoked immediately or throws
         coroutine.startUndispatchedOrReturn(coroutine, block)
     }
 }

kotlinx-coroutines-core/common/src/Supervisor.kt

@@ -1,5 +1,5 @@
 @file:OptIn(ExperimentalContracts::class)
-@file:Suppress("DEPRECATION_ERROR")
+@file:Suppress("LEAKED_IN_PLACE_LAMBDA", "WRONG_INVOCATION_KIND")
 
 package kotlinx.coroutines
 
@@ -53,7 +53,6 @@ public suspend fun <R> supervisorScope(block: suspend CoroutineScope.() -> R): R
     }
     return suspendCoroutineUninterceptedOrReturn { uCont ->
         val coroutine = SupervisorCoroutine(uCont.context, uCont)
-        @Suppress("LEAKED_IN_PLACE_LAMBDA") // Contract is preserved, invoked immediately or throws
         coroutine.startUndispatchedOrReturn(coroutine, block)
     }
 }

kotlinx-coroutines-core/common/src/Timeout.kt

@@ -1,4 +1,5 @@
 @file:OptIn(ExperimentalContracts::class)
+@file:Suppress("LEAKED_IN_PLACE_LAMBDA", "WRONG_INVOCATION_KIND")
 
 package kotlinx.coroutines
 
@@ -40,7 +41,6 @@ public suspend fun <T> withTimeout(timeMillis: Long, block: suspend CoroutineSco
     }
     if (timeMillis <= 0L) throw TimeoutCancellationException("Timed out immediately")
     return suspendCoroutineUninterceptedOrReturn { uCont ->
-        @Suppress("LEAKED_IN_PLACE_LAMBDA") // Contract is preserved, invoked immediately or throws
         setupTimeout(TimeoutCoroutine(timeMillis, uCont), block)
     }
 }

kotlinx-coroutines-core/common/src/channels/Channel.kt

@@ -1,5 +1,3 @@
-@file:Suppress("FunctionName")
-
 package kotlinx.coroutines.channels
 
 import kotlinx.coroutines.*

kotlinx-coroutines-core/common/src/flow/Migration.kt

@@ -1,6 +1,6 @@
 @file:JvmMultifileClass
 @file:JvmName("FlowKt")
-@file:Suppress("unused", "DeprecatedCallableAddReplaceWith", "UNUSED_PARAMETER", "NO_EXPLICIT_RETURN_TYPE_IN_API_MODE")
+@file:Suppress("unused", "DeprecatedCallableAddReplaceWith", "UNUSED_PARAMETER")
 
 package kotlinx.coroutines.flow
 

kotlinx-coroutines-core/common/src/internal/LockFreeLinkedList.common.kt

@@ -1,5 +1,3 @@
-@file:Suppress("NO_EXPLICIT_VISIBILITY_IN_API_MODE")
-
 package kotlinx.coroutines.internal
 
 /** @suppress **This is unstable API and it is subject to change.** */

kotlinx-coroutines-core/common/src/internal/Synchronized.common.kt

@@ -1,3 +1,5 @@
+@file:Suppress("LEAKED_IN_PLACE_LAMBDA", "WRONG_INVOCATION_KIND")
+
 package kotlinx.coroutines.internal
 
 import kotlinx.coroutines.*
@@ -24,6 +26,5 @@ public inline fun <T> synchronized(lock: SynchronizedObject, block: () -> T): T
     contract {
         callsInPlace(block, InvocationKind.EXACTLY_ONCE)
     }
-    @Suppress("LEAKED_IN_PLACE_LAMBDA") // Contract is preserved, invoked immediately or throws
     return synchronizedImpl(lock, block)
 }