Skip to content

Commit adce920

Browse files
timofey-solonindkhalanskyjb
authored andcommitted
Depend on root components instead of platform-specific components
The "-js" dependencies are an uncoventional way to specify dependencies and these dependencies are problematic for testing lenient KMP resolution.
1 parent fed1e60 commit adce920

File tree

3 files changed

+6
-49
lines changed

3 files changed

+6
-49
lines changed

buildSrc/src/main/kotlin/kotlin-multiplatform-conventions.gradle.kts

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ kotlin {
5959
outputModuleName = project.name
6060
nodejs()
6161
compilations["main"]?.dependencies {
62-
api("org.jetbrains.kotlinx:atomicfu-js:${version("atomicfu")}")
62+
api("org.jetbrains.kotlinx:atomicfu:${version("atomicfu")}")
6363
}
6464
}
6565
@OptIn(org.jetbrains.kotlin.gradle.ExperimentalWasmDsl::class)
@@ -69,14 +69,14 @@ kotlin {
6969
outputModuleName = project.name + "Wasm"
7070
nodejs()
7171
compilations["main"]?.dependencies {
72-
api("org.jetbrains.kotlinx:atomicfu-wasm-js:${version("atomicfu")}")
72+
api("org.jetbrains.kotlinx:atomicfu:${version("atomicfu")}")
7373
}
7474
}
7575
@OptIn(org.jetbrains.kotlin.gradle.ExperimentalWasmDsl::class)
7676
wasmWasi {
7777
nodejs()
7878
compilations["main"]?.dependencies {
79-
api("org.jetbrains.kotlinx:atomicfu-wasm-wasi:${version("atomicfu")}")
79+
api("org.jetbrains.kotlinx:atomicfu:${version("atomicfu")}")
8080
}
8181
compilations.configureEach {
8282
compileTaskProvider.configure {
@@ -90,8 +90,7 @@ kotlin {
9090
sourceSets {
9191
commonTest {
9292
dependencies {
93-
api("org.jetbrains.kotlin:kotlin-test-common:${version("kotlin")}")
94-
api("org.jetbrains.kotlin:kotlin-test-annotations-common:${version("kotlin")}")
93+
api("org.jetbrains.kotlin:kotlin-test:${version("kotlin")}")
9594
}
9695
}
9796
jvmMain.dependencies {
@@ -100,7 +99,6 @@ kotlin {
10099
api("org.jetbrains:annotations:23.0.0")
101100
}
102101
jvmTest.dependencies {
103-
api("org.jetbrains.kotlin:kotlin-test:${version("kotlin")}")
104102
// Workaround to make addSuppressed work in tests
105103
api("org.jetbrains.kotlin:kotlin-reflect:${version("kotlin")}")
106104
api("org.jetbrains.kotlin:kotlin-stdlib-jdk7:${version("kotlin")}")
@@ -112,24 +110,13 @@ kotlin {
112110
api("org.jetbrains.kotlinx:atomicfu:0.23.1")
113111
}
114112
jsMain { }
115-
jsTest {
116-
dependencies {
117-
api("org.jetbrains.kotlin:kotlin-test-js:${version("kotlin")}")
118-
}
119-
}
120113
val wasmJsMain by getting {
121114
}
122115
val wasmJsTest by getting {
123-
dependencies {
124-
api("org.jetbrains.kotlin:kotlin-test-wasm-js:${version("kotlin")}")
125-
}
126116
}
127117
val wasmWasiMain by getting {
128118
}
129119
val wasmWasiTest by getting {
130-
dependencies {
131-
api("org.jetbrains.kotlin:kotlin-test-wasm-wasi:${version("kotlin")}")
132-
}
133120
}
134121
groupSourceSets("jsAndWasmShared", listOf("web", "wasmWasi"), listOf("common"))
135122
}

integration-testing/smokeTest/build.gradle.kts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -45,26 +45,11 @@ kotlin {
4545
implementation(kotlin("test-common"))
4646
implementation(kotlin("test-annotations-common"))
4747
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-test:$coroutinesVersion")
48-
}
49-
}
50-
jsTest {
51-
dependencies {
52-
implementation(kotlin("test-js"))
53-
}
54-
}
55-
wasmJsTest {
56-
dependencies {
57-
implementation(kotlin("test-wasm-js"))
58-
}
59-
}
60-
wasmWasiTest {
61-
dependencies {
62-
implementation(kotlin("test-wasm-wasi"))
48+
implementation(kotlin("test"))
6349
}
6450
}
6551
jvmTest {
6652
dependencies {
67-
implementation(kotlin("test"))
6853
implementation(kotlin("test-junit"))
6954
}
7055
}

test-utils/build.gradle.kts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,29 +5,14 @@
55
kotlin {
66
sourceSets {
77
commonMain.dependencies {
8-
api("org.jetbrains.kotlin:kotlin-test-common:${version("kotlin")}")
9-
api("org.jetbrains.kotlin:kotlin-test-annotations-common:${version("kotlin")}")
8+
api("org.jetbrains.kotlin:kotlin-test:${version("kotlin")}")
109
}
1110
jvmMain.dependencies {
12-
api("org.jetbrains.kotlin:kotlin-test:${version("kotlin")}")
1311
// Workaround to make addSuppressed work in tests
1412
api("org.jetbrains.kotlin:kotlin-reflect:${version("kotlin")}")
1513
api("org.jetbrains.kotlin:kotlin-stdlib-jdk7:${version("kotlin")}")
1614
api("org.jetbrains.kotlin:kotlin-test-junit:${version("kotlin")}")
1715
api("junit:junit:${version("junit")}")
1816
}
19-
jsMain.dependencies {
20-
api("org.jetbrains.kotlin:kotlin-test-js:${version("kotlin")}")
21-
}
22-
val wasmJsMain by getting {
23-
dependencies {
24-
api("org.jetbrains.kotlin:kotlin-test-wasm-js:${version("kotlin")}")
25-
}
26-
}
27-
val wasmWasiMain by getting {
28-
dependencies {
29-
api("org.jetbrains.kotlin:kotlin-test-wasm-wasi:${version("kotlin")}")
30-
}
31-
}
3217
}
3318
}

0 commit comments

Comments
 (0)