Bug fix: start hangs on lazy coroutine with attached invokeOnCompletion

Author: elizarov

core/kotlinx-coroutines-core/src/main/kotlin/kotlinx/coroutines/experimental/Job.kt

@@ -1128,8 +1128,8 @@ public open class JobSupport(active: Boolean) : Job, SelectClause0, SelectClause
 
         fun tryMakeActive(): Int {
             if (_active.value != 0) return FALSE
-            if (_active.compareAndSet(0, 1)) return RETRY
-            return TRUE
+            if (_active.compareAndSet(0, 1)) return TRUE
+            return RETRY
         }
 
         override fun toString(): String = buildString {

core/kotlinx-coroutines-core/src/test/kotlin/kotlinx/coroutines/experimental/LaunchLazyTest.kt

@@ -20,7 +20,7 @@ import org.junit.Test
 
 class LaunchLazyTest : TestBase() {
     @Test
-    fun testLaunchAndYieldJoin() = runBlocking {
+    fun testLaunchAndYieldJoin() = runTest {
         expect(1)
         val job = launch(coroutineContext, CoroutineStart.LAZY) {
             expect(4)
@@ -37,7 +37,7 @@ class LaunchLazyTest : TestBase() {
     }
 
     @Test
-    fun testStart() = runBlocking {
+    fun testStart() = runTest {
         expect(1)
         val job = launch(coroutineContext, CoroutineStart.LAZY) {
             expect(5)
@@ -62,4 +62,22 @@ class LaunchLazyTest : TestBase() {
         job.join() // immediately returns
         finish(9)
     }
+
+    @Test
+    fun testInvokeOnCompletionAndStart() = runTest {
+        expect(1)
+        val job = launch(coroutineContext, CoroutineStart.LAZY) {
+            expect(5)
+        }
+        yield() // no started yet!
+        expect(2)
+        job.invokeOnCompletion {
+            expect(6)
+        }
+        expect(3)
+        job.start()
+        expect(4)
+        yield()
+        finish(7)
+    }
 }