Warn when SharedFlow.last() is called (#4468)

Fixes #3275
Also removes an unnecessary suppress (minor)

Author: murfel

kotlinx-coroutines-core/api/kotlinx-coroutines-core.klib.api

@@ -1145,6 +1145,7 @@ final suspend inline fun <#A: kotlin/Any?> (kotlinx.coroutines.channels/ReceiveC
 final suspend inline fun <#A: kotlin/Any?> (kotlinx.coroutines.flow/Flow<#A>).kotlinx.coroutines.flow/collect(crossinline kotlin.coroutines/SuspendFunction1<#A, kotlin/Unit>) // kotlinx.coroutines.flow/collect|collect@kotlinx.coroutines.flow.Flow<0:0>(kotlin.coroutines.SuspendFunction1<0:0,kotlin.Unit>){0§<kotlin.Any?>}[0]
 final suspend inline fun <#A: kotlin/Any?> (kotlinx.coroutines.flow/Flow<#A>).kotlinx.coroutines.flow/collectIndexed(crossinline kotlin.coroutines/SuspendFunction2<kotlin/Int, #A, kotlin/Unit>) // kotlinx.coroutines.flow/collectIndexed|collectIndexed@kotlinx.coroutines.flow.Flow<0:0>(kotlin.coroutines.SuspendFunction2<kotlin.Int,0:0,kotlin.Unit>){0§<kotlin.Any?>}[0]
 final suspend inline fun <#A: kotlin/Any?> (kotlinx.coroutines.flow/SharedFlow<#A>).kotlinx.coroutines.flow/count(): kotlin/Int // kotlinx.coroutines.flow/count|count@kotlinx.coroutines.flow.SharedFlow<0:0>(){0§<kotlin.Any?>}[0]
+final suspend inline fun <#A: kotlin/Any?> (kotlinx.coroutines.flow/SharedFlow<#A>).kotlinx.coroutines.flow/last(): #A // kotlinx.coroutines.flow/last|last@kotlinx.coroutines.flow.SharedFlow<0:0>(){0§<kotlin.Any?>}[0]
 final suspend inline fun <#A: kotlin/Any?> (kotlinx.coroutines.flow/SharedFlow<#A>).kotlinx.coroutines.flow/toList(): kotlin.collections/List<#A> // kotlinx.coroutines.flow/toList|toList@kotlinx.coroutines.flow.SharedFlow<0:0>(){0§<kotlin.Any?>}[0]
 final suspend inline fun <#A: kotlin/Any?> (kotlinx.coroutines.flow/SharedFlow<#A>).kotlinx.coroutines.flow/toList(kotlin.collections/MutableList<#A>): kotlin/Nothing // kotlinx.coroutines.flow/toList|toList@kotlinx.coroutines.flow.SharedFlow<0:0>(kotlin.collections.MutableList<0:0>){0§<kotlin.Any?>}[0]
 final suspend inline fun <#A: kotlin/Any?> (kotlinx.coroutines.flow/SharedFlow<#A>).kotlinx.coroutines.flow/toSet(): kotlin.collections/Set<#A> // kotlinx.coroutines.flow/toSet|toSet@kotlinx.coroutines.flow.SharedFlow<0:0>(){0§<kotlin.Any?>}[0]

kotlinx-coroutines-core/common/src/CoroutineDispatcher.kt

@@ -291,7 +291,6 @@ public abstract class CoroutineDispatcher :
      * CoroutineDispatcher is a coroutine context element and `+` is a set-sum operator for coroutine contexts.
      * The dispatcher to the right of `+` just replaces the dispatcher to the left.
      */
-    @Suppress("DeprecatedCallableAddReplaceWith")
     @Deprecated(
         message = "Operator '+' on two CoroutineDispatcher objects is meaningless. " +
             "CoroutineDispatcher is a coroutine context element and `+` is a set-sum operator for coroutine contexts. " +

kotlinx-coroutines-core/common/src/Job.kt

@@ -338,7 +338,6 @@ public interface Job : CoroutineContext.Element {
      * Job is a coroutine context element and `+` is a set-sum operator for coroutine contexts.
      * The job to the right of `+` just replaces the job the left of `+`.
      */
-    @Suppress("DeprecatedCallableAddReplaceWith")
     @Deprecated(message = "Operator '+' on two Job objects is meaningless. " +
         "Job is a coroutine context element and `+` is a set-sum operator for coroutine contexts. " +
         "The job to the right of `+` just replaces the job the left of `+`.",

kotlinx-coroutines-core/common/src/NonCancellable.kt

@@ -22,7 +22,6 @@ import kotlin.coroutines.*
  * The parent will not wait for the child's completion, nor will be cancelled when the child crashed.
  */
 @OptIn(InternalForInheritanceCoroutinesApi::class)
-@Suppress("DeprecatedCallableAddReplaceWith")
 public object NonCancellable : AbstractCoroutineContextElement(Job), Job {
 
     private const val message = "NonCancellable can be used only as an argument for 'withContext', direct usages of its API are prohibited"

kotlinx-coroutines-core/common/src/flow/operators/Lint.kt

@@ -134,7 +134,6 @@ public inline fun <T> SharedFlow<T>.retryWhen(noinline predicate: suspend FlowCo
 /**
  * @suppress
  */
-@Suppress("DeprecatedCallableAddReplaceWith")
 @Deprecated(
     message = "SharedFlow never completes, so this terminal operation never completes.",
     level = DeprecationLevel.WARNING
@@ -156,7 +155,6 @@ public suspend inline fun <T> SharedFlow<T>.toList(destination: MutableList<T>):
 /**
  * @suppress
  */
-@Suppress("DeprecatedCallableAddReplaceWith")
 @Deprecated(
     message = "SharedFlow never completes, so this terminal operation never completes.",
     level = DeprecationLevel.WARNING
@@ -178,11 +176,22 @@ public suspend inline fun <T> SharedFlow<T>.toSet(destination: MutableSet<T>): N
 /**
  * @suppress
  */
-@Suppress("DeprecatedCallableAddReplaceWith")
 @Deprecated(
     message = "SharedFlow never completes, so this terminal operation never completes.",
     level = DeprecationLevel.WARNING
 )
 @InlineOnly
 public suspend inline fun <T> SharedFlow<T>.count(): Int =
     (this as Flow<T>).count()
+
+/**
+ * @suppress
+ */
+@Deprecated(
+    message = "SharedFlow never completes, so this terminal operation never completes. " +
+        "If you are using last() to imitate a subscriber, use collect() instead.",
+    level = DeprecationLevel.WARNING,
+)
+@InlineOnly
+public suspend inline fun <T> SharedFlow<T>.last(): T =
+    (this as Flow<T>).last()