Rename DispatchException to CoroutinesInternalError and make it an Error to better reflect its semantics

Author: qwwdfsad

kotlinx-coroutines-core/common/src/Dispatched.kt

@@ -268,7 +268,7 @@ internal abstract class DispatchedTask<in T>(
         }
 
         val cause = exception ?: finallyException
-        val reason = DispatchException("Fatal exception in coroutines machinery for $this. " +
+        val reason = CoroutinesInternalError("Fatal exception in coroutines machinery for $this. " +
                 "Please read KDoc to 'handleFatalException' method and report this incident to maintainers", cause!!)
         handleExceptionViaHandler(this.delegate.context, reason)
     }

kotlinx-coroutines-core/common/src/Exceptions.common.kt

@@ -23,9 +23,8 @@ internal expect class JobCancellationException(
     internal val job: Job
 }
 
-internal expect class DispatchException(message: String, cause: Throwable) : RuntimeException
+internal expect class CoroutinesInternalError(message: String, cause: Throwable) : Error
 
 internal expect fun Throwable.addSuppressedThrowable(other: Throwable)
-
 // For use in tests
 internal expect val RECOVER_STACK_TRACES: Boolean

kotlinx-coroutines-core/js/src/Exceptions.kt

@@ -48,7 +48,7 @@ internal actual class JobCancellationException public actual constructor(
         (message!!.hashCode() * 31 + job.hashCode()) * 31 + (cause?.hashCode() ?: 0)
 }
 
-internal actual class DispatchException actual constructor(message: String, cause: Throwable) : RuntimeException(message.withCause(cause))
+internal actual class CoroutinesInternalError actual constructor(message: String, cause: Throwable) : Error(message.withCause(cause))
 
 @Suppress("FunctionName")
 internal fun IllegalStateException(message: String, cause: Throwable?) =

kotlinx-coroutines-core/jvm/src/Exceptions.kt

@@ -81,7 +81,7 @@ internal actual class JobCancellationException public actual constructor(
         (message!!.hashCode() * 31 + job.hashCode()) * 31 + (cause?.hashCode() ?: 0)
 }
 
-internal actual class DispatchException actual constructor(message: String, cause: Throwable) : RuntimeException(message, cause)
+internal actual class CoroutinesInternalError actual constructor(message: String, cause: Throwable) : Error(message, cause)
 
 @Suppress("NOTHING_TO_INLINE")
 internal actual inline fun Throwable.addSuppressedThrowable(other: Throwable) =

kotlinx-coroutines-core/jvm/test/FailingCoroutinesMachineryTest.kt

@@ -127,7 +127,7 @@ class FailingCoroutinesMachineryTest(
         val e = caught
         assertNotNull(e)
         // First condition -- failure in context element
-        val firstCondition = e is DispatchException && e.cause is TestException
+        val firstCondition = e is CoroutinesInternalError && e.cause is TestException
         // Second condition -- failure from isDispatchNeeded (#880)
         val secondCondition = e is TestException
         assertTrue(firstCondition xor secondCondition)

kotlinx-coroutines-core/native/src/Exceptions.kt

@@ -48,7 +48,7 @@ internal actual class JobCancellationException public actual constructor(
         (message!!.hashCode() * 31 + job.hashCode()) * 31 + (cause?.hashCode() ?: 0)
 }
 
-internal actual class DispatchException actual constructor(message: String, cause: Throwable) : RuntimeException(message.withCause(cause))
+internal actual class CoroutinesInternalError actual constructor(message: String, cause: Throwable) : Error(message.withCause(cause))
 
 @Suppress("FunctionName")
 internal fun IllegalStateException(message: String, cause: Throwable?) =