Fix builds for older Kotlin and kover

Author: Mr3zee

gradle-conventions-settings/develocity/src/main/kotlin/conventions-develocity.settings.gradle.kts

@@ -13,18 +13,18 @@ develocity {
     val startParameter = gradle.startParameter
     val scanJournal = File(settingsDir, "scan-journal.log")
 
-    server = DEVELOCITY_SERVER
+    server.set(DEVELOCITY_SERVER)
 
     buildScan {
-        uploadInBackground = !isCIRun
+        uploadInBackground.set(!isCIRun)
 
         // obfuscate NIC since we don't want to expose user real IP (will be relevant without VPN)
         obfuscation {
             ipAddresses { addresses -> addresses.map { _ -> "0.0.0.0" } }
         }
 
         capture {
-            fileFingerprints = true
+            fileFingerprints.set(true)
         }
 
         buildScanPublished {

gradle-conventions-settings/empty/build.gradle.kts

@@ -0,0 +1,36 @@
+/*
+ * Copyright 2023-2024 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license.
+ */
+
+import java.io.File
+import java.nio.file.Files
+import java.nio.file.Path
+
+plugins {
+    alias(libs.plugins.gradle.kotlin.dsl)
+}
+
+fun Path.name() = fileName?.toString().orEmpty()
+
+fun filterDirectory(sourceSetPath: Path, filter: (Path) -> Boolean): List<File> {
+    return Files.newDirectoryStream(sourceSetPath).use { it.toList() }.filter(filter).map { it.toFile() }
+}
+
+val pluginsSource: Path = layout.projectDirectory.dir("../develocity/src/main/kotlin").asFile.toPath()
+
+val plugins = filterDirectory(pluginsSource) {
+    Files.isRegularFile(it) && it.name().endsWith(".settings.gradle.kts")
+}.map { it.name.substringBefore('.') }
+
+plugins.forEach { name ->
+    gradlePlugin {
+        plugins {
+            create(name) {
+                id = name
+                implementationClass = "EmptySettingsPlugin"
+            }
+        }
+
+        logger.info("Applied $name precompiled plugin as stub")
+    }
+}

gradle-conventions-settings/empty/src/main/kotlin/empty-settings.settings.gradle.kts

@@ -0,0 +1,5 @@
+/*
+ * Copyright 2023-2024 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license.
+ */
+
+// Do not delete this. It is used as a stub plugin for latest-only plugins

gradle-conventions-settings/settings.gradle.kts

@@ -7,4 +7,10 @@ rootProject.name = "gradle-conventions-settings"
 // Code below is a hack because a chicken-egg problem, I can't use myself as a settings-plugin
 apply(from = "src/main/kotlin/settings-conventions.settings.gradle.kts")
 
-include(":develocity")
+val kotlinVersion: KotlinVersion by extra
+
+if (kotlinVersion.isAtLeast(1, 9, 0)) {
+    include(":develocity")
+} else {
+    include(":empty")
+}

gradle-conventions/latest-only/src/main/kotlin/conventions-kover.gradle.kts

@@ -14,7 +14,7 @@ the<KoverProjectExtension>().apply {
         total {
             html {
                 onCheck.set(false)
-                charset.set("UTF_8")
+                charset.set("UTF-8")
                 htmlDir.set(rootDir.resolve("kover"))
             }
 

tests/compiler-plugin-tests/build.gradle.kts

@@ -161,6 +161,6 @@ fun Test.setJarPathAsProperty(
 }
 
 fun Test.systemPropertyLogged(name: String, value: Any) {
-    logger.lifecycle("Setting test prop $name=$value")
+    logger.info("Setting test prop $name=$value")
     systemProperty(name, value)
 }