updating some notes based on feedback

Author: Jolanrensen

build.gradle.kts

@@ -191,7 +191,8 @@ allprojects {
     }
     tasks.withType<KotlinCompile> {
         compilerOptions {
-            // enables support for kotlin.time.Instant as kotlinx.datetime.Instant was deprecated
+            // enables support for kotlin.time.Instant as kotlinx.datetime.Instant was deprecated; Issue #1350
+            // Can be removed once kotlin.time.Instant is marked "stable".
             optIn.add("kotlin.time.ExperimentalTime")
         }
     }

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/convert.kt

@@ -399,7 +399,7 @@ internal fun createConverter(from: KType, to: KType, options: ParserOptions? = n
 
                 StdlibInstant::class -> convert<Int> { StdlibInstant.fromEpochMilliseconds(it.toLong()) }
 
-                // #1350
+                // Related to migration of kotlinx.datetime.Instant -> kotlin.time.Instant, Issue #1350
                 DeprecatedInstant::class -> convert<Int> { DeprecatedInstant.fromEpochMilliseconds(it.toLong()) }
 
                 JavaLocalDateTime::class -> convert<Int> {
@@ -440,7 +440,7 @@ internal fun createConverter(from: KType, to: KType, options: ParserOptions? = n
 
                 StdlibInstant::class -> convert<Byte> { StdlibInstant.fromEpochMilliseconds(it.toLong()) }
 
-                // #1350
+                // Related to migration of kotlinx.datetime.Instant -> kotlin.time.Instant, Issue #1350
                 DeprecatedInstant::class -> convert<Byte> { DeprecatedInstant.fromEpochMilliseconds(it.toLong()) }
 
                 JavaLocalDateTime::class -> convert<Byte> {
@@ -481,7 +481,7 @@ internal fun createConverter(from: KType, to: KType, options: ParserOptions? = n
 
                 StdlibInstant::class -> convert<Short> { StdlibInstant.fromEpochMilliseconds(it.toLong()) }
 
-                // #1350
+                // Related to migration of kotlinx.datetime.Instant -> kotlin.time.Instant, Issue #1350
                 DeprecatedInstant::class -> convert<Short> { DeprecatedInstant.fromEpochMilliseconds(it.toLong()) }
 
                 JavaLocalDateTime::class -> convert<Short> {
@@ -534,7 +534,7 @@ internal fun createConverter(from: KType, to: KType, options: ParserOptions? = n
 
                 StdlibInstant::class -> convert<Long> { StdlibInstant.fromEpochMilliseconds(it) }
 
-                // #1350
+                // Related to migration of kotlinx.datetime.Instant -> kotlin.time.Instant, Issue #1350
                 DeprecatedInstant::class -> convert<Long> { DeprecatedInstant.fromEpochMilliseconds(it) }
 
                 JavaLocalDateTime::class -> convert<Long> {
@@ -569,13 +569,13 @@ internal fun createConverter(from: KType, to: KType, options: ParserOptions? = n
 
                 JavaLocalTime::class -> convert<StdlibInstant> { it.toLocalTime(defaultTimeZone).toJavaLocalTime() }
 
-                // #1350
+                // Related to migration of kotlinx.datetime.Instant -> kotlin.time.Instant, Issue #1350
                 DeprecatedInstant::class -> convert<StdlibInstant> { it.toDeprecatedInstant() }
 
                 else -> null
             }
 
-            // #1350
+            // Related to migration of kotlinx.datetime.Instant -> kotlin.time.Instant, Issue #1350
             DeprecatedInstant::class -> when (toClass) {
                 Long::class -> convert<DeprecatedInstant> { it.toStdlibInstant().toEpochMilliseconds() }
 
@@ -631,7 +631,7 @@ internal fun createConverter(from: KType, to: KType, options: ParserOptions? = n
                     it.toKotlinInstant().toLocalTime(defaultTimeZone).toJavaLocalTime()
                 }
 
-                // #1350
+                // Related to migration of kotlinx.datetime.Instant -> kotlin.time.Instant, Issue #1350
                 DeprecatedInstant::class -> convert<JavaInstant> {
                     it.toKotlinInstant().toDeprecatedInstant()
                 }
@@ -682,7 +682,7 @@ internal fun createConverter(from: KType, to: KType, options: ParserOptions? = n
 
                 StdlibInstant::class -> convert<LocalDateTime> { it.toInstant(defaultTimeZone) }
 
-                // #1350
+                // Related to migration of kotlinx.datetime.Instant -> kotlin.time.Instant, Issue #1350
                 DeprecatedInstant::class -> convert<LocalDateTime> {
                     it.toInstant(defaultTimeZone).toDeprecatedInstant()
                 }
@@ -711,7 +711,7 @@ internal fun createConverter(from: KType, to: KType, options: ParserOptions? = n
                     it.toKotlinLocalDateTime().toInstant(defaultTimeZone)
                 }
 
-                // #1350
+                // Related to migration of kotlinx.datetime.Instant -> kotlin.time.Instant, Issue #1350
                 DeprecatedInstant::class -> convert<JavaLocalDateTime> {
                     it.toKotlinLocalDateTime().toInstant(defaultTimeZone).toDeprecatedInstant()
                 }
@@ -736,7 +736,7 @@ internal fun createConverter(from: KType, to: KType, options: ParserOptions? = n
 
                 StdlibInstant::class -> convert<LocalDate> { it.atStartOfDayIn(defaultTimeZone) }
 
-                // #1350
+                // Related to migration of kotlinx.datetime.Instant -> kotlin.time.Instant, Issue #1350
                 DeprecatedInstant::class -> convert<LocalDate> {
                     it.atStartOfDayIn(defaultTimeZone).toDeprecatedInstant()
                 }
@@ -761,7 +761,7 @@ internal fun createConverter(from: KType, to: KType, options: ParserOptions? = n
                     it.toKotlinLocalDate().atStartOfDayIn(defaultTimeZone)
                 }
 
-                // #1350
+                // Related to migration of kotlinx.datetime.Instant -> kotlin.time.Instant, Issue #1350
                 DeprecatedInstant::class -> convert<JavaLocalDate> {
                     it.toKotlinLocalDate().atStartOfDayIn(defaultTimeZone).toDeprecatedInstant()
                 }

docs/StardustDocs/topics/parse.md

@@ -36,7 +36,7 @@ df.parse { age and weight }
 `parse` tries to parse every `String` column into one of supported types in the following order:
 * `Int`
 * `Long`
-* `Instant` (`kotlin.time`) (requires `parseExperimentalInstant = true`)
+* `Instant` (`kotlin.time`) (requires `parseExperimentalInstant = true`, available from Kotlin 2.1+.)
 * `Instant` (`kotlinx.datetime` and `java.time`)
 * `LocalDateTime` (`kotlinx.datetime` and `java.time`)
 * `LocalDate` (`kotlinx.datetime` and `java.time`)
@@ -76,7 +76,7 @@ Available parser options:
 * `parseExperimentalUuid: Boolean` is used to enable or disable parsing to the experimental [`kotlin.uuid.Uuid` class](https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.uuid/-uuid/).
   * Disabled by global default
 * `parseExperimentalInstant: Boolean` is used to enable or disable parsing to the experimental 
-  [`kotlin.time.Instant` class](https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.time/-instant/).
+  [`kotlin.time.Instant` class](https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.time/-instant/), available from Kotlin 2.1+. Will parse to `kotlinx.datetime.Instant` if `false`.
   * Disabled by global default 
 
 <!---FUN parseWithOptions-->