Skip to content

Commit 737266b

Browse files
authored
Expand elevation-based documentation
1 parent 9c9643e commit 737266b

File tree

1 file changed

+20
-6
lines changed

1 file changed

+20
-6
lines changed

src/main/java/com/kosherjava/zmanim/ZmanimCalendar.java

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,16 @@
2323
import com.kosherjava.zmanim.util.GeoLocation;
2424

2525
/**
26-
* The ZmanimCalendar is a specialized calendar that can calculate sunrise and sunset and Jewish <em>zmanim</em>
26+
* The ZmanimCalendar is a specialized calendar that can calculate sunrise, sunset and Jewish <em>zmanim</em>
2727
* (religious times) for prayers and other Jewish religious duties. This class contains the main functionality of the
2828
* <em>Zmanim</em> library. For a much more extensive list of <em>zmanim</em>, use the {@link ComplexZmanimCalendar} that
2929
* extends this class. See documentation for the {@link ComplexZmanimCalendar} and {@link AstronomicalCalendar} for
30-
* simple examples on using the API. According to Rabbi Dovid Yehudah Bursztyn in his
31-
* <a href="https://www.worldcat.org/oclc/659793988">Zmanim Kehilchasam (second edition published in 2007)</a> chapter 2
32-
* (pages 186-187) no <em>zmanim</em> besides sunrise and sunset should use elevation. However, Rabbi Yechiel Avrahom
33-
* Zilber in the <a href="https://hebrewbooks.org/51654">Birur Halacha Vol. 6</a> Ch. 58 Pages
30+
* simple examples on using the API.
31+
* <strong>Elevation based <em>zmanim</em> (even sunrise and sunset) should not be used <em>lekula</em> without the guidance
32+
* of a <em>posek</em></strong>. According to Rabbi Dovid Yehudah Bursztyn in his
33+
* <a href="https://www.worldcat.org/oclc/1158574217">Zmanim Kehilchasam, 7th edition</a> chapter 2, section 7 (pages 181-182)
34+
* and section 9 (pages 186-187), no <em>zmanim</em> besides sunrise and sunset should use elevation. However, Rabbi Yechiel
35+
* Avrahom Zilber in the <a href="https://hebrewbooks.org/51654">Birur Halacha Vol. 6</a> Ch. 58 Pages
3436
* <a href="https://hebrewbooks.org/pdfpager.aspx?req=51654&amp;pgnum=42">34</a> and
3537
* <a href="https://hebrewbooks.org/pdfpager.aspx?req=51654&amp;pgnum=50">42</a> is of the opinion that elevation should be
3638
* accounted for in <em>zmanim</em> calculations. Related to this, Rabbi Yaakov Karp in <a href=
@@ -42,7 +44,19 @@
4244
* that are based on a fixed offset of sunrise or sunset and <em>zmanim</em> based on a percentage of the day such as
4345
* {@link ComplexZmanimCalendar#getSofZmanShmaMGA90MinutesZmanis()} that are based on sunrise and sunset. Even when set to
4446
* true it will not impact <em>zmanim</em> that are a degree-based offset of sunrise and sunset, such as {@link
45-
* ComplexZmanimCalendar#getSofZmanShmaMGA16Point1Degrees()} or {@link ComplexZmanimCalendar#getSofZmanShmaBaalHatanya()}.
47+
* ComplexZmanimCalendar#getSofZmanShmaMGA16Point1Degrees()} or {@link ComplexZmanimCalendar#getSofZmanShmaBaalHatanya()} since
48+
* these <em>zmanim</em> are not linked to sunrise or sunset times (the calculations are based on the astronomical definition of
49+
* sunrise and sunset calculated in a vacuum with the solar radius above the horizon), and are therefore not impacted by the use
50+
* of elevation.
51+
* For additional information on the <em>halachic</em> impact of elevation on <em>zmanim</em> see:
52+
* <ul>
53+
* <li><a href="https://www.nli.org.il/en/books/NNL_ALEPH002542826/NLI">Zmanei Halacha Lema'aseh</a> 4th edition by <a href=
54+
* "http://beinenu.com/rabbis/%D7%94%D7%A8%D7%91-%D7%99%D7%93%D7%99%D7%93%D7%99%D7%94-%D7%9E%D7%A0%D7%AA">Rabbi Yedidya Manat</a>.
55+
* See section 1, pages 11-12 for a very concise write-up, with details in section 2, pages 37 - 63 and 133 - 151.</li>
56+
* <li><a href="https://www.worldcat.org/oclc/1158574217">Zmanim Kehilchasam</a> 7th edition, by Rabbi Dovid Yehuda Burstein, vol 1,
57+
* chapter 2, pages 95 - 188.</li>
58+
* <li><a href="https://www.worldcat.org/oclc/36089452">Hazmanim Bahalacha</a> by Rabbi Chaim Banish , perek 7, pages 53 - 63.</li>
59+
* </ul>
4660
*
4761
* <p><b>Note:</b> It is important to read the technical notes on top of the {@link AstronomicalCalculator} documentation
4862
* before using this code.

0 commit comments

Comments
 (0)