minor #874 Increase phpstan to level 4 (acrobat)

This PR was merged into the 2.14.x-dev branch.

Discussion
----------



Commits
-------

877386b Phpstan level 2 fixes
92cad4d Phpstan level 4 fixes
cc3972b Use phpstan level 4 as default

Author: acrobat

lib/Github/Api/Apps.php

@@ -58,7 +58,7 @@ public function findInstallations()
      *
      * @link https://developer.github.com/v3/apps/#get-an-installation
      *
-     * @param $installationId An integration installation id
+     * @param int $installationId An integration installation id
      *
      * @return array
      */
@@ -74,7 +74,7 @@ public function getInstallation($installationId)
      *
      * @link https://developer.github.com/v3/apps/#get-an-organization-installation
      *
-     * @param $org An organization
+     * @param string $org An organization
      *
      * @return array
      */
@@ -90,8 +90,8 @@ public function getInstallationForOrganization($org)
      *
      * @link https://developer.github.com/v3/apps/#get-a-repository-installation
      *
-     * @param $owner the owner of a repository
-     * @param $repo the name of the repository
+     * @param string $owner the owner of a repository
+     * @param string $repo  the name of the repository
      *
      * @return array
      */
@@ -107,7 +107,7 @@ public function getInstallationForRepo($owner, $repo)
      *
      * @link https://developer.github.com/v3/apps/#get-a-user-installation
      *
-     * @param $username
+     * @param string $username
      *
      * @return array
      */
@@ -123,7 +123,7 @@ public function getInstallationForUser($username)
      *
      * @link https://developer.github.com/v3/apps/#delete-an-installation
      *
-     * @param $installationId An integration installation id
+     * @param int $installationId An integration installation id
      */
     public function removeInstallation($installationId)
     {

lib/Github/Api/Repository/Assets.php

@@ -67,8 +67,8 @@ public function show($username, $repository, $id)
      */
     public function create($username, $repository, $id, $name, $contentType, $content)
     {
-        if (!defined('OPENSSL_TLSEXT_SERVER_NAME') || !OPENSSL_TLSEXT_SERVER_NAME) {
-            throw new ErrorException('Asset upload support requires Server Name Indication. This is not supported by your PHP version. See http://php.net/manual/en/openssl.constsni.php.');
+        if (!defined('OPENSSL_TLSEXT_SERVER_NAME') || OPENSSL_TLSEXT_SERVER_NAME == 0) {
+            throw new ErrorException('Asset upload support requires Server Name Indication. This is not supported by your PHP version. See https://www.php.net/manual/en/openssl.constsni.php.');
         }
 
         // Asset creation requires a separate endpoint, uploads.github.com.

lib/Github/HttpClient/Plugin/Authentication.php

@@ -79,7 +79,6 @@ public function doHandleRequest(RequestInterface $request, callable $next, calla
 
             default:
                 throw new RuntimeException(sprintf('%s not yet implemented', $this->method));
-                break;
         }
 
         return $next($request);

phpstan.neon.dist

@@ -1,4 +1,4 @@
 parameters:
-	level: 0
-	paths:
-		- lib
+    level: 4
+    paths:
+        - lib