Add HEAD to allowed cacheable request types -- Thanks GrahamCampbell!

phpdreams · phpdreams · commit 6c27bd4b9060 · 2016-01-16T11:41:32.000-06:00
diff --git a/lib/Github/HttpClient/CachedHttpClient.php b/lib/Github/HttpClient/CachedHttpClient.php
@@ -68,7 +68,7 @@ public function request($path, $body = null, $httpMethod = 'GET', array $headers
             return $cacheResponse;
         }
 
-        if ($httpMethod == 'GET') {
+        if (in_array($httpMethod, array('GET', 'HEAD'), true)) {
             $this->getCache()->set($this->id, $response);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public function request($path, $body = null, $httpMethod = 'GET', array $headers`
`68`	`68`	`return $cacheResponse;`
`69`	`69`	`}`
`70`	`70`
`71`		`- if ($httpMethod == 'GET') {`
	`71`	`+ if (in_array($httpMethod, array('GET', 'HEAD'), true)) {`
`72`	`72`	`$this->getCache()->set($this->id, $response);`
`73`	`73`	`}`
`74`	`74`