Made implementation more consistent with DateTime, altered comments and tests accordingly

Author: dennisdegreef

lib/Github/Api/Notification.php

@@ -16,35 +16,36 @@ class Notification extends AbstractApi
 {
     /**
      * Get a listing of notifications
+     *
      * @link https://developer.github.com/v3/activity/notifications/
      *
-     * @param bool $includingRead
-     * @param bool $participating
-     * @param null $since
+     * @param bool          $includingRead
+     * @param bool          $participating
+     * @param DateTime|null $since
      *
      * @return array array of notifications
      */
-    public function all($includingRead = false, $participating = false, $since = null)
+    public function all($includingRead = false, $participating = false, DateTime $since = null)
     {
         $parameters = array(
             'all' => $includingRead,
             'participating' => $participating
         );
 
         if($since !== null) {
-            $parameters['since'] = $since;
+            $parameters['since'] = $since->format(DateTime::ISO8601);
         }
 
         return $this->get('notifications', $parameters);
     }
 
     /**
      * Marks all notifications as read from the current date
-     * Optionally give DateTimeInterface to mark as read before that date
+     * Optionally give DateTime to mark as read before that date
      *
      * @link https://developer.github.com/v3/activity/notifications/#mark-as-read
      *
-     * @param \DateTime $since
+     * @param DateTime|null $since
      */
     public function markRead(DateTime $since = null)
     {

test/Github/Tests/Api/NotificationTest.php

@@ -29,12 +29,12 @@ public function shouldGetNotifications()
      */
     public function shouldGetNotificationsSince()
     {
-        $since = '2015-01-01 00:00:00';
+        $since = new DateTime('now');
 
         $parameters = array(
             'all' => false,
             'participating' => false,
-            'since' => $since,
+            'since' => $since->format(DateTime::ISO8601),
         );
 
         $api = $this->getApiMock();