Merge pull request #163 from cmfcmf/patch-1

cursedcoder · cursedcoder · commit 39dc9b4be037 · 2014-08-01T02:03:14.000+03:00
Fixed error in cached HTTPClient - do not overwrite headers.
diff --git a/lib/Github/HttpClient/CachedHttpClient.php b/lib/Github/HttpClient/CachedHttpClient.php
@@ -72,7 +72,7 @@ public function request($path, $body = null, $httpMethod = 'GET', array $headers
      */
     protected function createRequest($httpMethod, $path, $body = null, array $headers = array(), array $options = array())
     {
-        $request = parent::createRequest($httpMethod, $path, $body, $headers = array(), $options);
+        $request = parent::createRequest($httpMethod, $path, $body, $headers, $options);
 
         if ($modifiedAt = $this->getCache()->getModifiedSince($path)) {
             $modifiedAt = new \DateTime('@'.$modifiedAt);

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public function request($path, $body = null, $httpMethod = 'GET', array $headers`
`72`	`72`	`*/`
`73`	`73`	`protected function createRequest($httpMethod, $path, $body = null, array $headers = array(), array $options = array())`
`74`	`74`	`{`
`75`		`- $request = parent::createRequest($httpMethod, $path, $body, $headers = array(), $options);`
	`75`	`+ $request = parent::createRequest($httpMethod, $path, $body, $headers, $options);`
`76`	`76`
`77`	`77`	`if ($modifiedAt = $this->getCache()->getModifiedSince($path)) {`
`78`	`78`	`$modifiedAt = new \DateTime('@'.$modifiedAt);`