feature #880 Make invalid request error more clear (acrobat)

acrobat · web-flow · commit 0ce1f0934724 · 2020-06-13T15:52:12.000+02:00
This PR was merged into the 2.15.x-dev branch. Discussion ---------- Closes #879 and closes #760 Commits ------- f84efb4 Make invalid request error more clear
diff --git a/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php b/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php
@@ -48,7 +48,7 @@ public function doHandleRequest(RequestInterface $request, callable $next, calla
             $content = ResponseMediator::getContent($response);
             if (is_array($content) && isset($content['message'])) {
                 if (400 === $response->getStatusCode()) {
-                    throw new ErrorException($content['message'], 400);
+                    throw new ErrorException(sprintf('%s (%s)', $content['message'], $response->getReasonPhrase()), 400);
                 }
 
                 if (422 === $response->getStatusCode() && isset($content['errors'])) {
diff --git a/test/Github/Tests/HttpClient/Plugin/GithubExceptionThrowerTest.php b/test/Github/Tests/HttpClient/Plugin/GithubExceptionThrowerTest.php
@@ -92,11 +92,11 @@ public static function responseProvider()
                     ],
                     json_encode(
                         [
-                            'message' => 'Bad Request',
+                            'message' => 'Problems parsing JSON',
                         ]
                     )
                 ),
-                'exception' => new \Github\Exception\ErrorException('Bad Request', 400),
+                'exception' => new \Github\Exception\ErrorException('Problems parsing JSON (Bad Request)', 400),
             ],
             '422 Unprocessable Entity' => [
                 'response' => new Response(

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public function doHandleRequest(RequestInterface $request, callable $next, calla`
`48`	`48`	`$content = ResponseMediator::getContent($response);`
`49`	`49`	`if (is_array($content) && isset($content['message'])) {`
`50`	`50`	`if (400 === $response->getStatusCode()) {`
`51`		`- throw new ErrorException($content['message'], 400);`
	`51`	`+ throw new ErrorException(sprintf('%s (%s)', $content['message'], $response->getReasonPhrase()), 400);`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`if (422 === $response->getStatusCode() && isset($content['errors'])) {`
Original file line number	Diff line number	Diff line change
`@@ -92,11 +92,11 @@ public static function responseProvider()`
`92`	`92`	`],`
`93`	`93`	`json_encode(`
`94`	`94`	`[`
`95`		`- 'message' => 'Bad Request',`
	`95`	`+ 'message' => 'Problems parsing JSON',`
`96`	`96`	`]`
`97`	`97`	`)`
`98`	`98`	`),`
`99`		`- 'exception' => new \Github\Exception\ErrorException('Bad Request', 400),`
	`99`	`+ 'exception' => new \Github\Exception\ErrorException('Problems parsing JSON (Bad Request)', 400),`
`100`	`100`	`],`
`101`	`101`	`'422 Unprocessable Entity' => [`
`102`	`102`	`'response' => new Response(`