Merge pull request #459 from kokspflanze/test/patch-2

added ::class in all tests

Author: cursedcoder

test/Github/Tests/Api/AbstractApiTest.php

@@ -20,7 +20,7 @@ public function shouldPassGETRequestToClient()
             ->method('get')
             ->with('/path?param1=param1value', array('header1' => 'header1value'))
             ->will($this->returnValue($this->getPSR7Response($expectedArray)));
-        $client = $this->getMockBuilder('Github\Client')
+        $client = $this->getMockBuilder(\Github\Client::class)
             ->setMethods(array('getHttpClient'))
             ->getMock();
         $client->expects($this->any())
@@ -49,7 +49,7 @@ public function shouldPassPOSTRequestToClient()
             ->with('/path', array('option1' => 'option1value'), json_encode(array('param1' => 'param1value')))
             ->will($this->returnValue($this->getPSR7Response($expectedArray)));
 
-        $client = $this->getMockBuilder('Github\Client')
+        $client = $this->getMockBuilder(\Github\Client::class)
             ->setMethods(array('getHttpClient'))
             ->getMock();
         $client->expects($this->any())
@@ -77,7 +77,7 @@ public function shouldPassPATCHRequestToClient()
             ->with('/path', array('option1' => 'option1value'), json_encode(array('param1' => 'param1value')))
             ->will($this->returnValue($this->getPSR7Response($expectedArray)));
 
-        $client = $this->getMockBuilder('Github\Client')
+        $client = $this->getMockBuilder(\Github\Client::class)
             ->setMethods(array('getHttpClient'))
             ->getMock();
         $client->expects($this->any())
@@ -162,7 +162,7 @@ public function shouldNotPassEmptyRefToClient()
             ->with('/path', array())
             ->will($this->returnValue($this->getPSR7Response($expectedArray)));
 
-        $client = $this->getMockBuilder('Github\Client')
+        $client = $this->getMockBuilder(\Github\Client::class)
             ->setMethods(array('getHttpClient'))
             ->getMock();
         $client->expects($this->any())
@@ -212,7 +212,7 @@ protected function getClientMock()
     protected function getHttpMethodsMock(array $methods = array())
     {
         $methods = array_merge(array('sendRequest'), $methods);
-        $mock = $this->getMockBuilder('Http\Client\Common\HttpMethodsClient')
+        $mock = $this->getMockBuilder(\Http\Client\Common\HttpMethodsClient::class)
             ->disableOriginalConstructor()
             ->setMethods($methods)
             ->getMock();
@@ -227,7 +227,7 @@ protected function getHttpMethodsMock(array $methods = array())
      */
     protected function getHttpClientMock()
     {
-        $mock = $this->getMockBuilder('Http\Client\HttpClient')
+        $mock = $this->getMockBuilder(\Http\Client\HttpClient::class)
             ->setMethods(array('sendRequest'))
             ->getMock();
         $mock

test/Github/Tests/Api/AuthorizationsTest.php

@@ -151,8 +151,11 @@ public function shouldRevokeAllAuthorizations()
         $api->revokeAll($id);
     }
 
+    /**
+     * @return string
+     */
     protected function getApiClass()
     {
-        return 'Github\Api\Authorizations';
+        return \Github\Api\Authorizations::class;
     }
 }

test/Github/Tests/Api/CurrentUser/DeployKeysTest.php

@@ -146,8 +146,11 @@ public function shouldRemoveKey()
         $this->assertEquals($expectedValue, $api->remove(123));
     }
 
+    /**
+     * @return string
+     */
     protected function getApiClass()
     {
-        return 'Github\Api\CurrentUser\DeployKeys';
+        return \Github\Api\CurrentUser\DeployKeys::class;
     }
 }

test/Github/Tests/Api/CurrentUser/EmailsTest.php

@@ -110,8 +110,11 @@ public function shouldNotAddEmailsWhenAreNotPass()
         $api->add(array());
     }
 
+    /**
+     * @return string
+     */
     protected function getApiClass()
     {
-        return 'Github\Api\CurrentUser\Emails';
+        return \Github\Api\CurrentUser\Emails::class;
     }
 }

test/Github/Tests/Api/CurrentUser/FollowersTest.php

@@ -65,8 +65,11 @@ public function shouldUnfollowUser()
         $this->assertNull($api->unfollow('l3l0'));
     }
 
+    /**
+     * @return string
+     */
     protected function getApiClass()
     {
-        return 'Github\Api\CurrentUser\Followers';
+        return \Github\Api\CurrentUser\Followers::class;
     }
 }

test/Github/Tests/Api/CurrentUser/MembershipsTest.php

@@ -84,8 +84,11 @@ public function shouldEditMembershipsForOrganization()
         $this->assertEquals($expectedValue, $api->edit('invitocat'));
     }
 
+    /**
+     * @return string
+     */
     protected function getApiClass()
     {
-        return 'Github\Api\CurrentUser\Memberships';
+        return \Github\Api\CurrentUser\Memberships::class;
     }
 }

test/Github/Tests/Api/CurrentUser/StarringTest.php

@@ -65,8 +65,11 @@ public function shouldUnstarUser()
         $this->assertNull($api->unstar('l3l0', 'test'));
     }
 
+    /**
+     * @return string
+     */
     protected function getApiClass()
     {
-        return 'Github\Api\CurrentUser\Starring';
+        return \Github\Api\CurrentUser\Starring::class;
     }
 }

test/Github/Tests/Api/CurrentUser/WatchersTest.php

@@ -65,8 +65,11 @@ public function shouldUnwatchUser()
         $this->assertNull($api->unwatch('l3l0', 'test'));
     }
 
+    /**
+     * @return string
+     */
     protected function getApiClass()
     {
-        return 'Github\Api\CurrentUser\Watchers';
+        return \Github\Api\CurrentUser\Watchers::class;
     }
 }

test/Github/Tests/Api/CurrentUserTest.php

@@ -91,7 +91,7 @@ public function shouldGetDeployKeysApiObject()
     {
         $api = $this->getApiMock();
 
-        $this->assertInstanceOf('Github\Api\CurrentUser\DeployKeys', $api->keys());
+        $this->assertInstanceOf(\Github\Api\CurrentUser\DeployKeys::class, $api->keys());
     }
 
     /**
@@ -101,7 +101,7 @@ public function shouldGetEmailsApiObject()
     {
         $api = $this->getApiMock();
 
-        $this->assertInstanceOf('Github\Api\CurrentUser\Emails', $api->emails());
+        $this->assertInstanceOf(\Github\Api\CurrentUser\Emails::class, $api->emails());
     }
 
     /**
@@ -111,7 +111,7 @@ public function shouldGetFollowersApiObject()
     {
         $api = $this->getApiMock();
 
-        $this->assertInstanceOf('Github\Api\CurrentUser\Followers', $api->follow());
+        $this->assertInstanceOf(\Github\Api\CurrentUser\Followers::class, $api->follow());
     }
 
     /**
@@ -121,7 +121,7 @@ public function shouldGetNotificationsApiObject()
     {
         $api = $this->getApiMock();
 
-        $this->assertInstanceOf('Github\Api\CurrentUser\Notifications', $api->notifications());
+        $this->assertInstanceOf(\Github\Api\CurrentUser\Notifications::class, $api->notifications());
     }
 
     /**
@@ -131,7 +131,7 @@ public function shouldGetWatchersApiObject()
     {
         $api = $this->getApiMock();
 
-        $this->assertInstanceOf('Github\Api\CurrentUser\Watchers', $api->watchers());
+        $this->assertInstanceOf(\Github\Api\CurrentUser\Watchers::class, $api->watchers());
     }
 
     /**
@@ -141,11 +141,14 @@ public function shouldGetStarredApiObject()
     {
         $api = $this->getApiMock();
 
-        $this->assertInstanceOf('Github\Api\CurrentUser\Starring', $api->starring());
+        $this->assertInstanceOf(\Github\Api\CurrentUser\Starring::class, $api->starring());
     }
 
+    /**
+     * @return string
+     */
     protected function getApiClass()
     {
-        return 'Github\Api\CurrentUser';
+        return \Github\Api\CurrentUser::class;
     }
 }

test/Github/Tests/Api/DeploymentTest.php

@@ -86,8 +86,11 @@ public function shouldGetAllStatuses()
         $api->getStatuses('KnpLabs', 'php-github-api', 1);
     }
 
+    /**
+     * @return string
+     */
     protected function getApiClass()
     {
-        return 'Github\Api\Deployment';
+        return \Github\Api\Deployment::class;
     }
 }