Skip to content

Commit 51af57c

Browse files
authored
Merge pull request Haehnchen#1293 from vdechenaux/fix_service_generation_class_bundle
Fix service generation when a class name contains "Bundle"and is not in a Bundle
2 parents de51080 + 401818d commit 51af57c

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

src/main/java/fr/adrienbrault/idea/symfony2plugin/action/generator/naming/DefaultServiceNameStrategy.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ public String getServiceName(@NotNull ServiceNameStrategyParameter parameter) {
4141
}
4242
}
4343

44+
if (x < 0) {
45+
return formatParts(Arrays.asList(split));
46+
}
47+
4448
Collection<String> parts = new ArrayList<>();
4549
parts.add(StringUtils.join(Arrays.copyOfRange(split, 0, x), "_"));
4650

src/test/java/fr/adrienbrault/idea/symfony2plugin/tests/action/naming/DefaultServiceNameStrategyTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ public void testThatOnlyBundleInSubNamespaceShouldBeStripped() {
3232
assertEquals("foobar_foo_bar_foo_bar_fo.foo_bar.foo_bar", defaultNaming.getServiceName(getParameter("Foobar\\FooBar\\FooBar\\FoBundle\\FooBar\\FooBar")));
3333
}
3434

35+
public void testThatServiceNotInBundleCanContainBundleWord() {
36+
DefaultServiceNameStrategy defaultNaming = new DefaultServiceNameStrategy();
37+
assertEquals("foo.foo_bar.search_bundle_subscriber", defaultNaming.getServiceName(getParameter("Foo\\FooBar\\SearchBundleSubscriber")));
38+
}
39+
3540
private ServiceNameStrategyParameter getParameter(String className) {
3641
return new ServiceNameStrategyParameter(getProject(), className);
3742
}

0 commit comments

Comments
 (0)