Skip to content

Commit 2804ed3

Browse files
committed
tests: treating pirated types as own
1 parent c2e98ff commit 2804ed3

File tree

3 files changed

+19
-1
lines changed

3 files changed

+19
-1
lines changed

Project.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ SIMDTypes = "0.1"
2727
Static = "0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 1"
2828
StaticArrayInterface = "1"
2929
julia = "1.10"
30+
Test = "<0.0.1, 1"
3031

3132
[extras]
3233
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

test/Project.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,7 @@ Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
33
ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"
44
InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
55
OffsetArrays = "6fe1bfb0-de20-5000-8ca7-80f57d26f881"
6+
LayoutPointers = "10f19ff3-798f-405d-979b-55457f8fc047"
67
SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"
78
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
9+
Static = "aedffcd0-7271-4cad-89d0-dc628f76c6d3"

test/runtests.jl

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,22 @@ include("testsetup.jl")
99
println("Aqua.test_all")
1010
t0 = time_ns()
1111
deps_compat = VERSION <= v"1.8" || isempty(VERSION.prerelease)
12-
Aqua.test_all(VectorizationBase; deps_compat = deps_compat)
12+
13+
# TODO - Will need a code refactor to properly address these type piracies.
14+
# Either:
15+
# 1. Create type wrappers in VectorizationBase
16+
# 2. Implement overloading upstream
17+
# 3. Use package extensions (still buggy in current Julia LTS v1.10.10)
18+
19+
pirated_types = [
20+
VectorizationBase.FastRange,
21+
VectorizationBase.AbstractStridedPointer,
22+
VectorizationBase.StridedBitPointer,
23+
VectorizationBase.StaticInt,
24+
VectorizationBase.AbstractSIMD,
25+
VectorizationBase.Bit,
26+
]
27+
Aqua.test_all(VectorizationBase; deps_compat = deps_compat, piracies=(treat_as_own = pirated_types,))
1328
println("Aqua took $((time_ns() - t0)*1e-9) seconds")
1429
# @test isempty(detect_unbound_args(VectorizationBase))
1530
# @test isempty(detect_ambiguities(VectorizationBase))

0 commit comments

Comments
 (0)