Fixed deprecations in SPMD.

All tests pass without deprecation warnings now.

Author: traktofon

src/spmd.jl

@@ -198,7 +198,7 @@ function scatter(x, pid::Int; tag=nothing, pids=procs())
             p == pid && continue
             send_msg(p, :scatter, x[cnt*(i-1)+1:cnt*i], tag)
         end
-        myidx = findfirst(sort(pids), pid)
+        myidx = findfirst(isequal(pid), sort(pids))
         return x[cnt*(myidx-1)+1:cnt*myidx]
     else
         _, data = get_msg(:scatter, pid, tag)
@@ -208,13 +208,13 @@ end
 
 function gather(x, pid::Int; tag=nothing, pids=procs())
     if myid() == pid
-        gathered_data = Array{Any}(length(pids))
-        myidx = findfirst(sort(pids), pid)
+        gathered_data = Array{Any}(undef, length(pids))
+        myidx = findfirst(isequal(pid), sort(pids))
         gathered_data[myidx] = x
         n = length(pids) - 1
         while n > 0
             from, data_x = get_msg(:gather, false, tag)
-            fromidx = findfirst(sort(pids), from)
+            fromidx = findfirst(isequal(from), sort(pids))
             gathered_data[fromidx] = data_x
             n=n-1
         end

test/spmd.jl

@@ -76,7 +76,7 @@ spmd(spmd_test1)
 # define the function everywhere
 @everywhere function foo_spmd(d_in, d_out, n)
     pids=sort(vec(procs(d_in)))
-    pididx = findfirst(pids, myid())
+    pididx = findfirst(isequal(myid()), pids)
     mylp = localpart(d_in)
     localsum = 0
 
@@ -122,7 +122,7 @@ println("SPMD: Passed testing of spmd function run concurrently")
 # define the function everywhere
 @everywhere function foo_spmd2(d_in, d_out, n)
     pids=sort(vec(procs(d_in)))
-    pididx = findfirst(pids, myid())
+    pididx = findfirst(isequal(myid()), pids)
     mylp = localpart(d_in)
 
     # see if we have a value in the local store.
@@ -170,7 +170,7 @@ end
 # verify localstores with appropriate context store values exist.
 @everywhere begin
     if myid() != 1
-        n = 0
+        local n = 0
         for (k,v) in DistributedArrays.SPMD.map_ctxts
             store = v.store
             localsum = store[:LOCALSUM]