performance optimizations #218
Open
+28
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw3126
reviewed
Dec 2, 2025
Comment on lines
+137
to
+138
| @generated _concat(a::NTuple{N,Any}, b::NTuple{M,Any}) where {N,M} = | ||
| :(Base.Cartesian.@ntuple $(N + M) i -> i ≤ $N ? a[i] : b[i - $N]) |
Member
There was a problem hiding this comment.
There is no reliably fast way to do this in Base?
jw3126
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessorsare known to be hard for the compiler to optimize sometimes, with compiler heuristics to stop optimizing triggering quite early.Here, I make the compiler "try harder": things like avoiding argument splatting, and making small inner functions more optimizable.
I recently used Accessors getall/setall with a few tens of elements – up to ~50. With these optimizations, it compiles down to almost nothing, while before there was a lot of dynamic dispatch inside.
Tests pass both before and after. Maybe I'll think of a short self-contained test demonstrating the improvements and add it... But I confirm in my testing that these changes greatly improve performance in such a regime.