tests for ref setindex

Author: balenamiaa

src/setindex.jl

@@ -2,6 +2,8 @@ Base.@propagate_inbounds function setindex(args...)
     Base.setindex(args...)
 end
 
+@inline setindex(::Base.RefValue, val) = Ref(val)
+
 Base.@propagate_inbounds function setindex(xs::AbstractArray, v, I...)
     T = promote_type(eltype(xs), typeof(v))
     ys = similar(xs, T)
@@ -21,8 +23,3 @@ Base.@propagate_inbounds function setindex(d0::AbstractDict, v, k)
     return d
 end
 
-Base.@propagate_inbounds function setindex(ref::Base.RefValue{Tx}, val::Ty) where {Tx, Ty}
-    T = promote_type(Tx, Ty)
-    new_ref = Base.RefValue{T}(convert(T, val))
-    return new_ref
-end

test/test_setindex.jl

@@ -15,6 +15,14 @@ Check that _type_ and value of `x` and `y` are equal.
     @test !(1.0 ==ₜ 1)
 end
 
+function ref_alloc_test()
+    ref = Ref((; a = 10, b = 0x0001, c = (; aa = 300)))
+    ref2 = Accessors.setindex(ref, (; a = 10, b = ref[].b - 1, c = (; aa = 300)))
+    ref3 = Accessors.setindex(ref, ref2[])
+
+    ref3[]
+end
+
 @testset "setindex" begin
     arr = [1,2,3]
     @test_throws MethodError Base.setindex(arr, 10, 1)
@@ -32,6 +40,15 @@ end
     @test d == Dict(:a => 1, :b => 2)
     @test Accessors.setindex(d, 30, "c") ==ₜ Dict(:a=>1, :b=>2, "c"=>30)
     @test Accessors.setindex(d, 10.0, :a) ==ₜ Dict(:a=>10.0, :b=>2.0)
+    
+    ref = Ref((; a = 10, b = 0x0001, c = (; aa = 300)))
+    @test @set(ref[].a = 90)[] == Ref((; a = 90, b = 0x0001, c = (; aa = 300)))[]
+    @test @set(ref[].b = Bool(ref[].b))[] == Ref((; a = 10, b = true, c = (; aa = 300)))[]
+    @test @set(ref[].c.aa = 3)[] == Ref((; a = 10, b = 0x0001, c = (; aa = 3)))[]
+
+    local val
+    @test @allocated(val = ref_alloc_test()) == 0
+    @test val == (; a = 10, b = 0x0000, c = (; aa = 300))
 end
 
 end