Implement setindex for Base.ImmutableDict

The design of Base.ImmutableDict allows the same key to be added again, which
shadows the previously added value. Unfortunately, it still prints out all of
the entries, including repeated keys. I thought this might be confusing, so I
implemented it to remove the value if the key exists and then add the new value.

Closes #216

Author: danielmatz

src/setindex.jl

@@ -24,6 +24,16 @@ Base.@propagate_inbounds function setindex(d0::AbstractDict, v, k)
     return d
 end
 
+function setindex(d0::Base.ImmutableDict, v, k)
+    d = Base.ImmutableDict(
+        (
+            key => value
+            for (key, value) in d0 if key != k
+        )...
+    )
+    Base.ImmutableDict(d, k => v)
+end
+
 # may be added to Base in https://github.com/JuliaLang/julia/pull/46453
 @inline function setindex(t::Tuple, v, inds::AbstractVector{<:Integer})
     ntuple(length(t)) do i

test/test_setindex.jl

@@ -43,6 +43,10 @@ end
     @test Accessors.setindex(d, 30, "c") ==ₜ Dict(:a=>1, :b=>2, "c"=>30)
     @test Accessors.setindex(d, 10.0, :a) ==ₜ Dict(:a=>10.0, :b=>2.0)
 
+    d = Base.ImmutableDict(:a => 1, :b => 2)
+    @test @set(d[:a] = 3) == Base.ImmutableDict(:a => 3, :b => 2)
+    @test @set(d[:c] = 3) == Base.ImmutableDict(:a => 1, :b => 2, :c => 3)
+
     nt = (a=1, b='2')
     @test @set(nt[:a] = "abc") == (a="abc", b='2')
     @test @set(nt[1] = "abc") == (a="abc", b='2')