further cleanup

Author: oscarddssmith

src/Quadmath.jl

@@ -198,8 +198,10 @@ Float128(x::Bool) = x ? Float128(1) : Float128(0)
 @assume_effects :foldable (/)(x::Float128, y::Float128) =
     Float128(@quad_ccall(quadoplib.__divtf3(x::Cfloat128, y::Cfloat128)::Cfloat128))
 
-@assume_effects :foldable (-)(x::Float128) =
-    Float128(@quad_ccall(quadoplib.__negtf2(x::Cfloat128)::Cfloat128))
+function (-)(x::Float128)
+    # xor by sign
+    reinterpret(Float128, reinterpret(UInt128, x) ⊻ sign_mask(Float128))
+end
 
 # Float128 -> Integer
 function unsafe_trunc(::Type{T}, x::Float128) where T<:Base.BitUnsigned
@@ -296,7 +298,7 @@ end
 
 function abs(x::Float128)
     # mask out sign
-    reinterpret(Float128, reinterpret(UInt128, x)&(~(UInt128(1)<<127)))
+    reinterpret(Float128, reinterpret(UInt128, x)&(~sign_mask(Float128)))
 end
 @assume_effects :foldable round(x::Float128) = Float128(@quad_ccall(libquadmath.rintq(x::Cfloat128)::Cfloat128))
 round(x::Float128, r::RoundingMode{:Down}) = floor(x)
@@ -329,6 +331,16 @@ Base.Integer(x::Float128) = Int(x)
 sincos(x::Float128) = (sin(x), cos(x))
 
 ## misc
+
+"""
+    Inf128
+
+Positive infinity of type [`Float128`](@ref).
+"""
+const Inf128 = reinterpret(Float128, exponent_mask(Float128))
+typemax(::Type{Float128}) = Inf128
+typemin(::Type{Float128}) = -Inf128
+
 @static if !Sys.iswindows()
     # disable fma on Windows until rounding mode issue fixed
     # https://github.com/JuliaMath/Quadmath.jl/issues/31
@@ -337,9 +349,7 @@ sincos(x::Float128) = (sin(x), cos(x))
 end
 
 function isinf(x::Float128)
-    xu = reinterpret(UInt128, x)
-    # xu must be either 0x7fff_0000... or 0xffff_0000...
-    return xu in (exponent_mask(Float128), exponent_mask(Float128)&~(UInt128(1)<<127))
+    return x===Inf128 || x===-Inf128
 end
 function isfinite(x::Float128)
     xu = reinterpret(UInt128, x)
@@ -360,15 +370,6 @@ floatmin(::Type{Float128}) = reinterpret(Float128, 0x0001_0000_0000_0000_0000_00
 floatmax(::Type{Float128}) = reinterpret(Float128, 0x7ffe_ffff_ffff_ffff_ffff_ffff_ffff_ffff)
 maxintfloat(::Type{Float128}) = Float128(0x0002_0000_0000_0000_0000_0000_0000_0000)
 
-"""
-    Inf128
-
-Positive infinity of type [`Float128`](@ref).
-"""
-const Inf128 = reinterpret(Float128, 0x7fff_0000_0000_0000_0000_0000_0000_0000)
-typemax(::Type{Float128}) = Inf128
-typemin(::Type{Float128}) = -Inf128
-
 @assume_effects :foldable ldexp(x::Float128, n::Cint) =
     Float128(@quad_ccall(libquadmath.ldexpq(x::Cfloat128, n::Cint)::Cfloat128))
 ldexp(x::Float128, n::Integer) =

src/printf.jl

@@ -1,60 +1,3 @@
-
-
-if VERSION < v"1.6.0-beta"
-    import Printf: ini_dec, fix_dec, ini_hex, ini_HEX
-
-    function fp128_printf(out, d::Float128, flags::String, width::Int, precision::Int, c::Char, digits)
-        fmt_len = sizeof(flags)+4
-        if width > 0
-            fmt_len += ndigits(width)
-        end
-        if precision >= 0
-            fmt_len += ndigits(precision)+1
-        end
-        fmt = IOBuffer(maxsize=fmt_len)
-        print(fmt, '%')
-        print(fmt, flags)
-        if width > 0
-            print(fmt, width)
-        end
-        if precision == 0
-            print(fmt, '.')
-            print(fmt, '0')
-        elseif precision > 0
-            print(fmt, '.')
-            print(fmt, precision)
-        end
-        print(fmt, 'Q')
-        print(fmt, c)
-        write(fmt, UInt8(0))
-        printf_fmt = take!(fmt)
-        @assert length(printf_fmt) == fmt_len
-        bufsiz = length(digits)
-        lng = @ccall(libquadmath.quadmath_snprintf(digits::Ptr{UInt8}, bufsiz::Csize_t, printf_fmt::Ptr{UInt8}, d::(Cfloat128...))::Cint)
-        lng > 0 || error("invalid printf formatting for Float128")
-        unsafe_write(out, pointer(digits), min(lng, bufsiz-1))
-        return (false, ())
-    end
-
-    if VERSION < v"1.1"
-        using Base.Grisu: DIGITSs
-        fix_dec(out, d::Float128, flags::String, width::Int, precision::Int, c::Char) = fp128_printf(out, d, flags, width, precision, c, DIGITSs[Threads.threadid()])
-        ini_dec(out, d::Float128, ndigits::Int, flags::String, width::Int, precision::Int, c::Char) = fp128_printf(out, d, flags, width, precision, c, DIGITSs[Threads.threadid()])
-        ini_hex(out, d::Float128, ndigits::Int, flags::String, width::Int, precision::Int, c::Char) = fp128_printf(out, d, flags, width, precision, c, DIGITSs[Threads.threadid()])
-        ini_HEX(out, d::Float128, ndigits::Int, flags::String, width::Int, precision::Int, c::Char) = fp128_printf(out, d, flags, width, precision, c, DIGITSs[Threads.threadid()])
-        ini_hex(out, d::Float128, flags::String, width::Int, precision::Int, c::Char) = fp128_printf(out, d, flags, width, precision, c, DIGITSs[Threads.threadid()])
-        ini_HEX(out, d::Float128, flags::String, width::Int, precision::Int, c::Char) = fp128_printf(out, d, flags, width, precision, c, DIGITSs[Threads.threadid()])
-    else
-        fix_dec(out, d::Float128, flags::String, width::Int, precision::Int, c::Char, digits) = fp128_printf(out, d, flags, width, precision, c, digits)
-        ini_dec(out, d::Float128, ndigits::Int, flags::String, width::Int, precision::Int, c::Char, digits) = fp128_printf(out, d, flags, width, precision, c, digits)
-        ini_hex(out, d::Float128, ndigits::Int, flags::String, width::Int, precision::Int, c::Char, digits) = fp128_printf(out, d, flags, width, precision, c, digits)
-        ini_HEX(out, d::Float128, ndigits::Int, flags::String, width::Int, precision::Int, c::Char, digits) = fp128_printf(out, d, flags, width, precision, c, digits)
-        ini_hex(out, d::Float128, flags::String, width::Int, precision::Int, c::Char, digits) = fp128_printf(out, d, flags, width, precision, c, digits)
-        ini_HEX(out, d::Float128, flags::String, width::Int, precision::Int, c::Char, digits) = fp128_printf(out, d, flags, width, precision, c, digits)
-    end
-else
-    # Julia v1.6+
-    # placeholder
-    import Printf
-    Printf.tofloat(x::Float128) = BigFloat(x)
-end
+# placeholder
+import Printf
+Printf.tofloat(x::Float128) = BigFloat(x)