Fix ambiguities, might still need to fix Constant(::Periodic)

Author: mkitti

src/Interpolations.jl

@@ -109,7 +109,13 @@ struct InPlaceQ{GT<:Union{GridType,Nothing}} <: BoundaryCondition gt::GT end
 const Natural = Line
 
 (::Type{BC})() where BC<:BoundaryCondition = BC(nothing)
-(::Type{BC})(::Type{GT}) where {GT <: GridType, BC<:BoundaryCondition} = BC{GT}(GT())
+# (::Type{BC})(::Type{GT}) where {GT <: GridType, BC<:BoundaryCondition} = BC{GT}(GT())
+for BC in (:Throw, :Flat, :Line, :Free, :Reflect, :InPlace)
+    eval(quote
+        $BC(::Type{GT}) where GT <: GridType = $BC{GT}(GT())
+        $BC{GT}(::Type{GT}) where GT <: GridType = $BC{GT}(GT())
+    end)
+end
 function Base.show(io::IO, bc::BoundaryCondition)
     print(io, nameof(typeof(bc)), '(')
     bc.gt === nothing || show(io, bc.gt)

src/b-splines/constant.jl

@@ -37,9 +37,10 @@ struct Constant{T<:ConstantInterpType,BC<:Union{Throw{OnGrid},Periodic{OnCell}}}
 end
 
 # Default to Nearest and Throw{OnGrid}
-Constant(args...) = Constant{Nearest}(args...)
+Constant() = Constant{Nearest}()
 Constant{T}() where {T<:ConstantInterpType} = Constant{T,Throw{OnGrid}}(Throw(OnGrid()))
 Constant{T}(bc::BC) where {T<:ConstantInterpType,BC<:BoundaryCondition} = Constant{T,BC}(bc)
+Constant(p::Periodic) where {T<:ConstantInterpType} = Constant{Nearest}(p)
 Constant{T}(::Periodic{Nothing}) where {T<:ConstantInterpType} = Constant{T,Periodic{OnCell}}(Periodic(OnCell()))
 Constant(::Type{T}) where T <: ConstantInterpType = Constant{T}()
 

src/b-splines/cubic.jl

@@ -5,6 +5,8 @@ end
 (deg::Cubic)(gt::GridType) = Cubic(deg.bc(gt))
 # Default constructor to match cubic_spline_interpolation
 Cubic() = Cubic(Line(OnGrid()))
+Cubic{BC}(::Type{BC}) where BC <: BoundaryCondition = Cubic{BC}(BC())
+Cubic{BC}(::Type{BC2}) where {BC <: BoundaryCondition, BC2 <: BoundaryCondition} = throw(ArgumentError("Argument must match type parameter"))
 
 """
     Cubic(bc::BoundaryCondition)

src/b-splines/quadratic.jl

@@ -3,6 +3,8 @@ struct Quadratic{BC<:BoundaryCondition} <: DegreeBC{2}
 end
 # Default constructor
 Quadratic() = Quadratic(Line(OnGrid()))
+Quadratic{BC}(::Type{BC}) where BC <: BoundaryCondition = Quadratic{BC}(BC())
+Quadratic{BC}(::Type{BC2}) where {BC <: BoundaryCondition, BC2 <: BoundaryCondition} = throw(ArgumentError("Argument must match type parameter"))
 (deg::Quadratic)(gt::GridType) = Quadratic(deg.bc(gt))