Use TriangularSolve for Butterfly factorization #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
test failure |
Contributor
|
@oscardssmith you forgot to change the tests to match the new function name so that's why tests are broken. |
Contributor
Author
|
resolved. |
Member
|
still failing |
Contributor
|
huh all the tests fail now, something broke |
Contributor
Author
|
turns out |
Contributor
Author
|
@ChrisRackauckas tests passing. LGTM |
ChrisRackauckas
merged commit a94d5f8
into
JuliaLinearAlgebra:master
20 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #103 with minor cleanups and a rename of
🦋lu!to🦋solve!to reflect what the function actually does.