fixes

Author: Shreyas-Ekanathan

src/butterflylu.jl

@@ -21,7 +21,10 @@ function 🦋generate_random!(A, ::Val{SEED} = Val(888)) where {SEED}
 end
 
 function 🦋workspace(A, B::Matrix{T}, U::Adjoint{T, Matrix{T}}, V::Matrix{T}, ::Val{SEED} = Val(888)) where {T, SEED}
-    A = pad!(A)
+    M = size(A, 1)
+    if (M % 4 != 0)
+        A = pad!(A)
+    end
     B = similar(A)
     ws = 🦋generate_random!(copyto!(B, A))
     🦋mul!(copyto!(B, A), ws)

test/runtests.jl

@@ -81,11 +81,14 @@ end
     for i in 790 : 810
         A = wilkinson(i)
         b = rand(i)
-        U, V, F = RecursiveFactorization.🦋workspace(A, A', A)
-        M, N = size(A)
+        U, V, F = RecursiveFactorization.🦋workspace(A, A, A', A)
+        M = size(A, 1)
         xn = 4 - M % 4
-        b_ext = [b; rand(xn)]
-        x = V * (F \ (U * b_ext))    
-        @test norm(A * x[1:M] .- b) <= 1e-10
+        if (M % 4 != 0)
+            xn = 4 - M % 4
+            b = [b; rand(xn)]
+        end
+        x = V * (F \ (U * b))    
+        @test norm(A * x[1:M] .- b[1:M]) <= 1e-10
     end
 end