Commit 3032fcb
rebase (#1)
* Update README.md
* Fix negative info values for NoPivot() on Julia 1.11+
Julia 1.11 changed the convention for LU factorization info field when using NoPivot().
Now, when a zero diagonal is encountered during unpivoted LU factorization, the info
field should be negative to distinguish it from pivoted factorization failures.
This commit updates RecursiveFactorization to match Julia's convention:
- In _generic_lufact!, return negative info when Pivot=false and zero diagonal found
- In reckernel!, handle negative info values correctly when adjusting offsets
Fixes #95
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Update ci.yml
* Update ci.yml
* Add VERSION check for Julia 1.11+ negative info convention
Only use negative info values for NoPivot() on Julia 1.11 and later.
Earlier versions should continue using positive info values.
- Added NOPIVOT_NEGATIVE_INFO constant that checks Julia version
- Use this constant to conditionally apply negative info values
- Ensures backward compatibility with Julia < 1.11
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Update README.md
---------
Co-authored-by: ChrisRackauckas <me@chrisrackauckas.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Christopher Rackauckas <accounts@chrisrackauckas.com>1 parent be2d727 commit 3032fcb
2 files changed
+16
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
235 | 237 | | |
236 | 238 | | |
237 | 239 | | |
238 | | - | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
239 | 248 | | |
240 | 249 | | |
241 | 250 | | |
| |||
303 | 312 | | |
304 | 313 | | |
305 | 314 | | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
306 | 319 | | |
307 | 320 | | |
308 | 321 | | |
| |||
0 commit comments