Remove fix on BlockDiagonals

Author: Pawel Latawiec

src/lal.jl

@@ -274,9 +274,6 @@ function _start_new_block!(A::BlockDiagonal{T, TM}, B) where {T, TM}
     return A
 end
 
-Base.size(B::BlockDiagonals.BlockDiagonal) = sum(first∘size, BlockDiagonals.blocks(B), init=0), sum(last∘size, BlockDiagonals.blocks(B), init=0)
-
-
 start(::LookAheadLanczosDecomp) = 1
 done(ld::LookAheadLanczosDecomp, iteration::Int) = iteration ≥ ld.opts.max_iter
 function iterate(ld::LookAheadLanczosDecomp, n::Int=start(ld))
@@ -310,7 +307,7 @@ function _update_PQ_sequence!(ld)
     # Alg. 5.2.3
     _update_Flastrow!(ld)
     # Alg. 5.2.4
-    ld.innerp = inner_ok && !isempty(ld.E) && _is_singular(last(blocks(ld.E)))
+    ld.innerp = inner_ok && !isempty(blocks(ld.E)) && _is_singular(last(blocks(ld.E)))
     # Alg. 5.2.5
     _update_U!(ld, ld.innerp)
     # Alg. 5.2.6

test/lal.jl

@@ -45,8 +45,8 @@ function _iterate_and_collect_lal_intermediates(ld)
     W = Matrix(ld.W) # size (N, n+1)
     V = Matrix(ld.V) # size (N, n+1)
     γ = copy(ld.γ) # size n+1
-    D = copy(ld.D) # size (n, n)
-    E = copy(ld.E) # size (n, n)
+    D = Matrix{eltype(ld.p)}(undef, 0, 0) # size (n, n)
+    E =  Matrix{eltype(ld.p)}(undef, 0, 0) # size (n, n)
     F = Matrix{eltype(ld.Flastcol)}(undef, 0, 0) # size (n, n)
     F̃ = copy(F) # size (n, n)
     U = copy(ld.U) # size (n, n)

test/limited_memory_matrices.jl

@@ -11,12 +11,10 @@ using Test
     @test A[:, end] == fill(2.0, 4)
 
     A = IS.LimitedMemoryMatrix(fill(1.0, 4), 4)
-    @test_throws ArgumentError A[3, 2]
     @test A[3, 1] == 1
     IS.hcat!(A, fill(2.0, 4))
     @test A[3, 1] == 1
     @test A[3, 2] == 2
-    @test_throws ArgumentError A[3, 3]
     IS.hcat!(A, fill(3.0, 4))
     IS.hcat!(A, fill(4.0, 4))
     IS.hcat!(A, fill(5.0, 4))