Fix Tests (#165)

* Fix Tests

* Test on v1

Author: dlfivefifty

.github/workflows/ci.yml

@@ -38,6 +38,7 @@ jobs:
       matrix:
         version:
           - '1.9'
+          - '1'
         os:
           - ubuntu-latest
           - macOS-latest

Project.toml

@@ -1,6 +1,6 @@
 name = "InfiniteLinearAlgebra"
 uuid = "cde9dba0-b1de-11e9-2c62-0bab9446c55c"
-version = "0.7.3"
+version = "0.7.4"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/banded/hessenbergq.jl

@@ -147,8 +147,17 @@ end
 # getindex
 ####
 
+function _getindex_by_col(Q, I, J)
+    T = eltype(Q)
+    ret = Matrix{T}(undef, length(I), length(J))
+    for j in J
+        ret[:,j] = Q[:,j][I]
+    end
+    ret
+end
+
 getindex(Q::UpperHessenbergQ, I::AbstractVector{Int}, J::AbstractVector{Int}) =
-    hcat((Q[:,j][I] for j in J)...)
+    _getindex_by_col(Q, I, J)
 
 getindex(Q::LowerHessenbergQ, i::Int, j::Int) = (Q')[j,i]'
 getindex(Q::LowerHessenbergQ, I::AbstractVector{Int}, J::AbstractVector{Int}) =

src/banded/infqltoeplitz.jl

@@ -127,7 +127,7 @@ if VERSION < v"1.8-"
     end
 end
 getindex(Q::ProductQ, I::AbstractVector{Int}, J::AbstractVector{Int}) =
-        hcat((Q[:,j][I] for j in J)...)
+    _getindex_by_col(Q, I, J)
 
 getindex(Q::ProductQ{<:Any,<:Tuple{Vararg{LowerHessenbergQ}}}, i::Int, j::Int) = (Q')[j, i]'
 

src/infqr.jl

@@ -163,7 +163,7 @@ partialqr!(F::AdaptiveQRFactors, n) = partialqr!(F.data, n)
 #########
 
 getindex(Q::QRPackedQ{<:Any,<:AdaptiveQRFactors,<:AdaptiveQRTau}, I::AbstractVector{Int}, J::AbstractVector{Int64}) =
-    hcat((Q[:,j][I] for j in J)...)
+    _getindex_by_col(Q, I, J)
 
 #########
 # lmul!

test/test_infql.jl

@@ -198,7 +198,7 @@ using ArrayLayouts: TriangularLayout, UnknownLayout
 
             @test (L*Q)[1:10,1:10] ≈ LazyBandedMatrices.SymTridiagonal(L*Q)[1:10,1:10]
             @test Q[5,6:8] == [Q[5,k] for k = 6:8]
-            @test Q[6:8,5] == [Q[k,5] for k = 6:8]
+            @test Q[6:8,5] ≈ [Q[k,5] for k = 6:8]
         end
 
         @test_throws ErrorException ql(zeros(∞,∞))