Clean-up of version-dependent code (#97)

Author: dkarrasch

src/eigenGeneral.jl

@@ -247,41 +247,26 @@ _eigvals!(A::StridedMatrix; kwargs...)           = _eigvals!(_schur!(A; kwargs..
 _eigvals!(H::HessenbergMatrix; kwargs...)        = _eigvals!(_schur!(H; kwargs...))
 _eigvals!(H::HessenbergFactorization; kwargs...) = _eigvals!(_schur!(H; kwargs...))
 
-# Overload methods from LinearAlgebra to make them work generically
-if VERSION > v"1.2.0-DEV.0"
-    function LinearAlgebra.eigvals!(
-        A::StridedMatrix;
-        sortby::Union{Function,Nothing}=LinearAlgebra.eigsortby,
-        kwargs...)
-        
-        if ishermitian(A)
-            return LinearAlgebra.sorteig!(eigvals!(Hermitian(A)), sortby)
-        end
-        LinearAlgebra.sorteig!(_eigvals!(A; kwargs...), sortby)
-    end
-
-    LinearAlgebra.eigvals!(
-        H::HessenbergMatrix;
-        sortby::Union{Function,Nothing}=LinearAlgebra.eigsortby,
-        kwargs...) = LinearAlgebra.sorteig!(_eigvals!(H; kwargs...), sortby)
-
-    LinearAlgebra.eigvals!(
-        H::HessenbergFactorization;
-        sortby::Union{Function,Nothing}=LinearAlgebra.eigsortby,
-        kwargs...) = LinearAlgebra.sorteig!(_eigvals!(H; kwargs...), sortby)
-else
-    function LinearAlgebra.eigvals!(A::StridedMatrix; kwargs...)
-        if ishermitian(A)
-            return eigvals!(Hermitian(A))
-        else
-            return _eigvals!(A; kwargs...)
-        end
+function LinearAlgebra.eigvals!(
+    A::StridedMatrix;
+    sortby::Union{Function,Nothing}=LinearAlgebra.eigsortby,
+    kwargs...)
+    
+    if ishermitian(A)
+        return LinearAlgebra.sorteig!(eigvals!(Hermitian(A)), sortby)
     end
+    LinearAlgebra.sorteig!(_eigvals!(A; kwargs...), sortby)
+end
 
-    LinearAlgebra.eigvals!(H::HessenbergMatrix; kwargs...) = _eigvals!(H; kwargs...)
+LinearAlgebra.eigvals!(
+    H::HessenbergMatrix;
+    sortby::Union{Function,Nothing}=LinearAlgebra.eigsortby,
+    kwargs...) = LinearAlgebra.sorteig!(_eigvals!(H; kwargs...), sortby)
 
-    LinearAlgebra.eigvals!(H::HessenbergFactorization; kwargs...) = _eigvals!(H; kwargs...)
-end
+LinearAlgebra.eigvals!(
+    H::HessenbergFactorization;
+    sortby::Union{Function,Nothing}=LinearAlgebra.eigsortby,
+    kwargs...) = LinearAlgebra.sorteig!(_eigvals!(H; kwargs...), sortby)
 
 # To compute the eigenvalue of the pseudo triangular Schur matrix we just return
 # the values of the 1x1 diagonal blocks and compute the eigenvalues of the 2x2

src/svd.jl

@@ -303,23 +303,15 @@ function Base.getproperty(F::BidiagonalFactorization, s::Symbol)
         if s === :leftQ
             return LinearAlgebra.QRPackedQ(R, τl)
         elseif s === :rightQ
-            if VERSION < v"1.3.0-DEV.243"
-                return LinearAlgebra.HessenbergQ(copy(transpose(R[1:size(R,2),:])), τr)
-            else
-                factors = copy(transpose(R[1:size(R,2),:]))
-                return LinearAlgebra.HessenbergQ{eltype(factors),typeof(factors),typeof(τr),false}('U', factors, τr)
-            end
+            factors = copy(transpose(R[1:size(R,2),:]))
+            return LinearAlgebra.HessenbergQ{eltype(factors),typeof(factors),typeof(τr),false}('U', factors, τr)
         else
             return getfield(F, s)
         end
     else
         if s === :leftQ
-            if VERSION < v"1.3.0-DEV.243"
-                return LinearAlgebra.HessenbergQ(R[:,1:size(R,1)], τl)
-            else
-                factors = R[:,1:size(R,1)]
-                return LinearAlgebra.HessenbergQ{eltype(factors),typeof(factors),typeof(τr),false}('U', factors, τl)
-            end
+            factors = R[:,1:size(R,1)]
+            return LinearAlgebra.HessenbergQ{eltype(factors),typeof(factors),typeof(τr),false}('U', factors, τl)
         elseif s === :rightQ
             # return transpose(LinearAlgebra.LQPackedQ(R, τr)) # FixMe! check that this shouldn't be adjoint
             LinearAlgebra.QRPackedQ(copy(transpose(R)), τr)

test/eigengeneral.jl

@@ -14,9 +14,7 @@ cplxord = t -> (real(t), imag(t))
     vBig    = eigvals(big.(A)) # not defined in LinearAlgebra so will dispatch to the version in GenericLinearAlgebra
     @test sort(vGLA, by = cplxord) ≈ sort(vLAPACK, by = cplxord)
     @test sort(vGLA, by = cplxord) ≈ sort(complex(eltype(A)).(vBig), by = cplxord)
-    if VERSION > v"1.2.0-DEV.0"
-        @test issorted(vBig, by = cplxord)
-    end
+    @test issorted(vBig, by = cplxord)
 end
 
 @testset "make sure that solver doesn't hang" begin
@@ -86,11 +84,7 @@ end
         (7 - adjoint(z1)*z2),
         (7 + [2, 2]'*z2)])/3
 
-    if VERSION > v"1.2.0-DEV.0"
-        @test eigvals(big.(A)) ≈ truevals
-    else
-        @test sort(eigvals(big.(A)), by=real) ≈ truevals
-    end
+    @test eigvals(big.(A)) ≈ truevals
 end
 
 Demmel(η) = [0  1 0 0