Merge pull request #115 from JuliaLinearAlgebra/an/morecoverage

Some more test coverage to svd.jl

Author: andreasnoack

src/svd.jl

@@ -392,6 +392,7 @@ function Base.getproperty(F::BidiagonalFactorization, s::Symbol)
                 τl,
             )
         elseif s === :rightQ
+            # FIXME! Can I get the LQPackedQ versino going to avoid the copy?
             # return transpose(LinearAlgebra.LQPackedQ(R, τr)) # FixMe! check that this shouldn't be adjoint
             LinearAlgebra.QRPackedQ(copy(transpose(R)), τr)
         else
@@ -502,30 +503,32 @@ function rmul!(A::AbstractMatrix, adjQ::AdjointQtype{<:Any,<:LinearAlgebra.Hesse
     return A
 end
 
-function rmul!(A::AbstractMatrix, Q::LinearAlgebra.LQPackedQ)
-
-    m, n = size(A)
-
-    if n != size(Q, 1)
-        throw(DimensionMismatch(""))
-    end
-
-    for i = 1:m
-        for l = length(Q.τ):-1:1
-            τl = Q.τ[l]
-            ṽ = view(Q.factors, l, (l+1):n)
-            aᵀ = transpose(view(A, i, (l+1):n))
-            aᵀv = A[i, l]
-            if length(ṽ) > 0
-                aᵀv += aᵀ * ṽ
-            end
-            A[i, l] -= aᵀv * τl
-            aᵀ .-= aᵀv .* τl .* ṽ'
-        end
-    end
-
-    return A
-end
+# FIXME! Commented out for now because we currently don't produce
+# any LQPackedQ matrices.
+# function rmul!(A::AbstractMatrix, Q::LinearAlgebra.LQPackedQ)
+
+#     m, n = size(A)
+
+#     if n != size(Q, 1)
+#         throw(DimensionMismatch(""))
+#     end
+
+#     for i = 1:m
+#         for l = length(Q.τ):-1:1
+#             τl = Q.τ[l]
+#             ṽ = view(Q.factors, l, (l+1):n)
+#             aᵀ = transpose(view(A, i, (l+1):n))
+#             aᵀv = A[i, l]
+#             if length(ṽ) > 0
+#                 aᵀv += aᵀ * ṽ
+#             end
+#             A[i, l] -= aᵀv * τl
+#             aᵀ .-= aᵀv .* τl .* ṽ'
+#         end
+#     end
+
+#     return A
+# end
 
 # Overload LinearAlgebra methods
 

test/svd.jl

@@ -235,4 +235,10 @@ using Test, GenericLinearAlgebra, LinearAlgebra, Quaternions, DoubleFloats
         F = GenericLinearAlgebra._svd!(copy(B))
         @test diag(F.U' * B * F.Vt') ≈ F.S rtol = 5e-15
     end
+
+    @testset "HessenbergQ multiplicatin" begin
+        A = randn(10, 10)
+        BF = GenericLinearAlgebra.bidiagonalize!(copy(A))
+        @test BF.rightQ'*Matrix(I, size(A)...)*BF.rightQ ≈ I
+    end
 end