cleaning up arithmetic / bitwise ops

Author: leios

src/atomics.jl

@@ -29,12 +29,20 @@ function __atomic(ex)
     error("@atomic macro incomplete!")
 end
 
-function atomic_add!(ptr, b)
-    Core.Intrinsics.atomic_pointermodify(ptr, +, b, :monotonic)
-end
-
-function atomic_and!(ptr, b)
-    Core.Intrinsics.atomic_pointermodify(ptr, &, b, :monotonic)
+# arithmetic and bitwise operations
+
+const ops = Dict(
+    :atomic_add!   => +,
+    :atomic_sub!   => -,
+    :atomic_and!   => &,
+    :atomic_or!    => -,
+    :atomic_xor!   => ⊻,
+)
+
+for (name, op) in ops
+    @eval @inline function $name(ptr, b)
+        Core.Intrinsics.atomic_pointermodify(ptr, $op, b, :monotonic)
+    end
 end
 
 # Not sure what this one is...
@@ -67,24 +75,11 @@ function atomic_op!(ptr, b)
     Core.Intrinsics.atomic_pointermodify(ptr, &, b, :monotonic)
 end
 
-function atomic_or!(ptr, b)
-    Core.Intrinsics.atomic_pointermodify(ptr, |, b, :monotonic)
-end
-
-function atomic_sub!(ptr, b)
-    Core.Intrinsics.atomic_pointermodify(ptr, -, b, :monotonic)
-end
-
 # TODO
 function atomic_xchg!(ptr, b)
     Core.Intrinsics.atomic_pointermodify(ptr, &, b, :monotonic)
 end
 
-# TODO
-function atomic_xor!(ptr, b)
-    Core.Intrinsics.atomic_pointermodify(ptr, &, b, :monotonic)
-end
-
 ###
 # CPU implementation of atomic macro
 ###