Fix and test opnorm for sparse (#650)

* Fix and test opnorm for sparse

* Use sprandn

* Don't use linalg tests with complex int

* Fix subtype check

* Just don't do Ints for linalg tests

Author: kshyatt

src/host/sparse.jl

@@ -75,7 +75,7 @@ function LinearAlgebra.opnorm(A::AbstractGPUSparseMatrixCSR, p::Real=2)
     end
 end
 
-LinearAlgebra.opnorm(A::AbstractGPUSparseMatrixCSC, p::Real=2) = opnorm(_csr_type(A)(A), p)
+LinearAlgebra.opnorm(A::AbstractGPUSparseMatrixCSC, p::Real=2) = opnorm(csr_type(A)(A), p)
 
 function LinearAlgebra.norm(A::AbstractGPUSparseMatrix{T}, p::Real=2) where T
     if p == Inf

test/testsuite/sparse.jl

@@ -10,6 +10,7 @@
             matrix_construction(sparse_AT, eltypes)
             broadcasting_matrix(sparse_AT, eltypes)
             mapreduce_matrix(sparse_AT, eltypes)
+            linalg(sparse_AT, eltypes)
        end
     end
 end
@@ -336,3 +337,27 @@ function mapreduce_matrix(AT, eltypes)
         end
     end
 end
+
+function linalg(AT, eltypes)
+    dense_AT = GPUArrays.dense_array_type(AT)
+    for ET in eltypes
+        # sprandn doesn't work nicely with these...
+        if !(ET <: Union{Int16, Int32, Int64, Complex{Int16}, Complex{Int32}, Complex{Int64}})
+            @testset "Sparse matrix($ET) linear algebra" begin
+                m = 10
+                A  = sprandn(ET, m, m, 0.2)
+                B  = sprandn(ET, m, m, 0.3)
+                ZA = spzeros(ET, m, m)
+                C  = I(div(m, 2))
+                dA = AT(A)
+                dB = AT(B)
+                dZA = AT(ZA)
+                @testset "opnorm and norm" begin
+                    @test opnorm(A, Inf) ≈ opnorm(dA, Inf)
+                    @test opnorm(A, 1)   ≈ opnorm(dA, 1)
+                    @test_throws ArgumentError opnorm(dA, 2)
+                end
+            end
+        end
+    end
+end