Merge pull request #165 from JuliaDiff/ox/covectors

Make rand_tangent on adjoint an transpose return natural

Author: oxinabox

src/rand_tangent.jl

@@ -13,11 +13,13 @@ rand_tangent(rng::AbstractRNG, x::Integer) = NoTangent()
 
 rand_tangent(rng::AbstractRNG, x::T) where {T<:Number} = randn(rng, T)
 
-# TODO: right now Julia don't allow `randn(rng, BigFloat)` 
+# TODO: right now Julia don't allow `randn(rng, BigFloat)`
 # see: https://github.com/JuliaLang/julia/issues/17629
 rand_tangent(rng::AbstractRNG, ::BigFloat) = big(randn(rng))
 
 rand_tangent(rng::AbstractRNG, x::StridedArray) = rand_tangent.(Ref(rng), x)
+rand_tangent(rng::AbstractRNG, x::Adjoint) = adjoint(rand_tangent(rng, parent(x)))
+rand_tangent(rng::AbstractRNG, x::Transpose) = transpose(rand_tangent(rng, parent(x)))
 
 function rand_tangent(rng::AbstractRNG, x::T) where {T<:Tuple}
     return Tangent{T}(rand_tangent.(Ref(rng), x)...)

test/rand_tangent.jl

@@ -24,6 +24,11 @@ using FiniteDifferences: rand_tangent
         (randn(Complex{Float32}, 5, 4), Matrix{Complex{Float32}}),
         ([randn(5, 4), 4.0], Vector{Any}),
 
+        # Wrapper Arrays
+        (randn(5, 4)', Adjoint{Float64, Matrix{Float64}}),
+        (transpose(randn(5, 4)), Transpose{Float64, Matrix{Float64}}),
+
+
         # Tuples.
         ((4.0, ), Tangent{Tuple{Float64}}),
         ((5.0, randn(3)), Tangent{Tuple{Float64, Vector{Float64}}}),
@@ -66,20 +71,19 @@ using FiniteDifferences: rand_tangent
             Hermitian(randn(ComplexF64, 1, 1)),
             Tangent{Hermitian{ComplexF64, Matrix{ComplexF64}}},
         ),
-        (
-            Adjoint(randn(ComplexF64, 3, 3)),
-            Tangent{Adjoint{ComplexF64, Matrix{ComplexF64}}},
-        ),
-        (
-            Transpose(randn(3)),
-            Tangent{Transpose{Float64, Vector{Float64}}},
-        ),
     ]
         @test rand_tangent(rng, x) isa T_tangent
         @test rand_tangent(x) isa T_tangent
-        @test x + rand_tangent(rng, x) isa typeof(x)
     end
 
-    # Ensure struct fallback errors for non-struct types.
-    @test_throws ArgumentError invoke(rand_tangent, Tuple{AbstractRNG, Any}, rng, 5.0)
+    @testset "erroring cases" begin
+        # Ensure struct fallback errors for non-struct types.
+        @test_throws ArgumentError invoke(rand_tangent, Tuple{AbstractRNG, Any}, rng, 5.0)
+    end
+
+    @testset "compsition of addition" begin
+        x = Foo(1.5, 2, Foo(1.1, 3, [1.7, 1.4, 0.9]))
+        @test x + rand_tangent(x) isa typeof(x)
+        @test x + (rand_tangent(x) + rand_tangent(x)) isa typeof(x)
+    end
 end