Move sparse logabsdet from structured to sparsematrix

Author: ElOceanografo

src/rulesets/LinearAlgebra/structured.jl

@@ -268,40 +268,3 @@ function rrule(::typeof(logdet), X::Union{Diagonal, AbstractTriangular})
     end
     return y, logdet_pullback
 end
-
-function rrule(::typeof(logabsdet), x::SparseMatrixCSC)
-    F = cholesky(x)
-    L, D, U, P = SparseInverseSubset.get_ldup(F)
-    Ω = logabsdet(D)
-    function logabsdet_pullback(ΔΩ)
-        (Δy, Δsigny) = ΔΩ
-        (_, signy) = Ω
-        f = signy' * Δsigny
-        imagf = f - real(f)
-        g = real(Δy) + imagf
-        Z, P = sparseinv(F, depermute=true)
-        ∂x = g * Z'
-        return (NoTangent(), ∂x)
-    end
-    return Ω, logabsdet_pullback
-end
-
-function rrule(::typeof(logdet), x::SparseMatrixCSC)
-    Ω = logdet(x)
-    function logdet_pullback(ΔΩ)
-        Z, p = sparseinv(x, depermute=true)
-        ∂x = ΔΩ * Z'
-        return (NoTangent(), ∂x)
-    end
-    return Ω, logdet_pullback
-end
-
-function rrule(::typeof(det), x::SparseMatrixCSC)
-    Ω = det(x)
-    function det_pullback(ΔΩ)
-        Z, _ = sparseinv(x, depermute=true)
-        ∂x = Z' * dot(Ω, ΔΩ)
-        return (NoTangent(), ∂x)
-    end
-    return Ω, det_pullback
-end

src/rulesets/SparseArrays/sparsematrix.jl

@@ -49,3 +49,41 @@ function rrule(::typeof(findnz), v::AbstractSparseVector)
 
     return (I, V), findnz_pullback
 end
+
+
+function rrule(::typeof(logabsdet), x::SparseMatrixCSC)
+    F = cholesky(x)
+    L, D, U, P = SparseInverseSubset.get_ldup(F)
+    Ω = logabsdet(D)
+    function logabsdet_pullback(ΔΩ)
+        (Δy, Δsigny) = ΔΩ
+        (_, signy) = Ω
+        f = signy' * Δsigny
+        imagf = f - real(f)
+        g = real(Δy) + imagf
+        Z, P = sparseinv(F, depermute=true)
+        ∂x = g * Z'
+        return (NoTangent(), ∂x)
+    end
+    return Ω, logabsdet_pullback
+end
+
+function rrule(::typeof(logdet), x::SparseMatrixCSC)
+    Ω = logdet(x)
+    function logdet_pullback(ΔΩ)
+        Z, p = sparseinv(x, depermute=true)
+        ∂x = ΔΩ * Z'
+        return (NoTangent(), ∂x)
+    end
+    return Ω, logdet_pullback
+end
+
+function rrule(::typeof(det), x::SparseMatrixCSC)
+    Ω = det(x)
+    function det_pullback(ΔΩ)
+        Z, _ = sparseinv(x, depermute=true)
+        ∂x = Z' * dot(Ω, ΔΩ)
+        return (NoTangent(), ∂x)
+    end
+    return Ω, det_pullback
+end

test/rulesets/LinearAlgebra/structured.jl

@@ -161,14 +161,4 @@
             end
         end
     end
-
-    @testset "[log[abs[det]]] SparseMatrixCSC" begin
-        ii = 1:5
-        jj = 1:5
-        x = ones(5)
-        A = sparse(ii, jj, x)
-        test_rrule(logabsdet, A)
-        test_rrule(logdet, A)
-        test_rrule(det, A)
-    end
 end

test/rulesets/SparseArrays/sparsematrix.jl

@@ -33,3 +33,13 @@ end
     V̄ = rand!(similar(V))
     test_rrule(findnz, v ⊢ dv, output_tangent=(zeros(length(I)), V̄))
 end
+
+@testset "[log[abs[det]]] SparseMatrixCSC" begin
+    ii = 1:5
+    jj = 1:5
+    x = ones(5)
+    A = sparse(ii, jj, x)
+    test_rrule(logabsdet, A)
+    test_rrule(logdet, A)
+    test_rrule(det, A)
+end