-
Notifications
You must be signed in to change notification settings - Fork 3
changed: fill inequality vector g even if -Inf bounds
#291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It probably does not save much computation and this is a source of bug (since i'm filling `g` in-place) Let's benchmark this change in a separate PR
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
=======================================
Coverage 98.50% 98.51%
=======================================
Files 28 28
Lines 4831 4833 +2
=======================================
+ Hits 4759 4761 +2
Misses 72 72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
|
There is small visible impact on the MHE pendulum case study, which is the only case study that really tests nonlinear inequality constraints. Let's not merge this PR, it seems that it DOES help the performances. |
It probably does not save much computation and this is a source of future bug (since i'm filling
gin-place). I shot myself in the foot multiple time because of this small "performance optimization".Let's benchmark this change in a separate PR.