define propertynames() to be consistent with getproperty() (#1289)

* define propertynames() to be consistent with getproperty()

* Update src/MVector.jl

Co-authored-by: Neven Sajko <4944410+nsajko@users.noreply.github.com>

* handle :data

* Update src/MVector.jl

Co-authored-by: Neven Sajko <4944410+nsajko@users.noreply.github.com>

* fix

* bump version

* Update Project.toml

---------

Co-authored-by: Neven Sajko <4944410+nsajko@users.noreply.github.com>
Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>

Author: 3 people

Project.toml

@@ -1,6 +1,6 @@
 name = "StaticArrays"
 uuid = "90137ffa-7385-5640-81b9-e52037218182"
-version = "1.9.10"
+version = "1.9.11"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/MVector.jl

@@ -18,6 +18,11 @@ end
 let dimension_names = QuoteNode.([:x, :y, :z, :w])
     body = :(getfield(v, name))
     for (i,dim_name) in enumerate(dimension_names)
+        @eval @inline function Base.propertynames(v::Union{SVector{$i},MVector{$i}}, private::Bool = false)
+            named_dims = ($(first(dimension_names, i)...),)
+            private ? (named_dims..., :data) : named_dims
+        end
+
         body = :(name === $(dimension_names[i]) ? getfield(v, :data)[$i] : $body)
         @eval @inline function Base.getproperty(v::Union{SVector{$i},MVector{$i}},
                                                 name::Symbol)
@@ -33,3 +38,6 @@ let dimension_names = QuoteNode.([:x, :y, :z, :w])
         end
     end
 end
+
+# for longer S/MVectors and other S/MArrays, the only property is data, and it's private
+Base.propertynames(::Union{SArray,MArray}, private::Bool = false) = private ? (:data,) : ()

test/SVector.jl

@@ -151,12 +151,19 @@
     end
 
     @testset "Named field access - getproperty" begin
+        @test propertynames(SA[1,2,3,4,5]) == ()
+        @test propertynames(SA[1,2,3,4,5], true) == (:data,)
+        @test propertynames(SA[1 2; 3 4], true) == (:data,)
         v4 = SA[10,20,30,40]
+        @test propertynames(v4) == (:x, :y, :z, :w)
+        @test propertynames(v4, true) == (:x, :y, :z, :w, :data)
         @test v4.x == 10
         @test v4.y == 20
         @test v4.z == 30
         @test v4.w == 40
         v2 = SA[10,20]
+        @test propertynames(v2) == (:x, :y)
+        @test propertynames(v2, true) == (:x, :y, :data)
         @test v2.x == 10
         @test v2.y == 20
         @test_throws ErrorException v2.z