Merge pull request #305 from hyrodium/fix/setindex

Remove unnecessary methods from `setindex`

Author: ChrisRackauckas

lib/ArrayInterfaceCore/src/ArrayInterfaceCore.jl

@@ -307,16 +307,6 @@ function Base.setindex(x::AbstractArray, v, i...)
     return _x
 end
 
-function Base.setindex(x::AbstractVector, v, i::Int)
-    n = length(x)
-    x .* (i .!== 1:n) .+ v .* (i .== 1:n)
-end
-
-function Base.setindex(x::AbstractMatrix, v, i::Int, j::Int)
-    n, m = Base.size(x)
-    x .* (i .!== 1:n) .* (j .!== i:m)' .+ v .* (i .== 1:n) .* (j .== i:m)'
-end
-
 """
     can_setindex(::Type{T}) -> Bool
 

lib/ArrayInterfaceCore/test/runtests.jl

@@ -234,6 +234,11 @@ end
         @test iszero(x)
         @test all(isone, y2)
     end
+
+    @testset "string" begin
+        x = fill("a", 2, 3)
+        @test setindex(x, "b", 2, 1) == setindex(x, "b", CartesianIndex(2, 1)) == ["a" "a" "a";"b" "a" "a"]
+    end
 end
 
 @testset "Sparsity Structure" begin