Make SubArrays that aren't StridedArrays be CPUIndex.

Author: chriselrod

Project.toml

@@ -1,6 +1,6 @@
 name = "ArrayInterface"
 uuid = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"
-version = "2.14.1"
+version = "2.14.2"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/ArrayInterface.jl

@@ -567,6 +567,13 @@ device(::Type) = nothing
 device(::Type{<:Tuple}) = CPUIndex()
 # Relies on overloading for GPUArrays that have subtyped `StridedArray`.
 device(::Type{<:StridedArray}) = CPUPointer()
+function device(::Type{T}) where {T <: SubArray}
+    if T <: StridedArray
+        device(parent_type(T))
+    else
+        CPUIndex()
+    end
+end
 function device(::Type{T}) where {T <: AbstractArray}
     P = parent_type(T)
     T === P ? CPUIndex() : device(P)

test/runtests.jl

@@ -272,6 +272,8 @@ Base.getindex(::DummyZeros{T}, inds...) where {T} = zero(T)
     @test device(PermutedDimsArray(A,(3,1,2))) === ArrayInterface.CPUPointer()
     @test device(view(A, 1, :, 2:4)) === ArrayInterface.CPUPointer()
     @test device(view(A, 1, :, 2:4)') === ArrayInterface.CPUPointer()
+    @test device(view(A, 1, :, [2,3,4])) === ArrayInterface.CPUIndex()
+    @test device(view(A, 1, :, [2,3,4])') === ArrayInterface.CPUIndex()
     @test device(@SArray(zeros(2,2,2))) === ArrayInterface.CPUIndex()
     @test device(@view(@SArray(zeros(2,2,2))[1,1:2,:])) === ArrayInterface.CPUIndex()
     @test device(@MArray(zeros(2,2,2))) === ArrayInterface.CPUPointer()