Merge pull request #378 from JuliaArrays/cleanup

A bit more cleanup

Author: ChrisRackauckas

.github/workflows/Documentation.yml

@@ -1,4 +1,5 @@
 name: Documentation
+
 on:
   push:
     branches:
@@ -14,10 +15,14 @@ jobs:
       - uses: julia-actions/setup-julia@latest
         with:
           version: '1'
-      - run: julia --project -e 'using Pkg; Pkg.develop([PackageSpec(path=joinpath(pwd(), "lib", "ArrayInterfaceCore"))])'
-      - uses: julia-actions/julia-buildpkg@latest
-      - run: julia --project=docs/ -e 'using Pkg; Pkg.develop([PackageSpec(path=joinpath(pwd(), "lib", "ArrayInterfaceCore"))]); Pkg.instantiate()'
-      - uses: julia-actions/julia-docdeploy@releases/v1
+      - name: Install dependencies
+        run: julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()'
+      - name: Build and deploy
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          DOCUMENTER_KEY: ${{ secrets.DOCUMENTER_KEY }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # For authentication with GitHub Actions token
+          DOCUMENTER_KEY: ${{ secrets.DOCUMENTER_KEY }} # For authentication with SSH deploy key
+        run: julia --project=docs/ --code-coverage=user docs/make.jl
+      - uses: julia-actions/julia-processcoverage@v1
+      - uses: codecov/codecov-action@v1
+        with:
+          file: lcov.info

.github/workflows/Downstream.yml

@@ -30,8 +30,7 @@ jobs:
           - {user: SciML, repo: OrdinaryDiffEq.jl, group: Core}
           - {user: SciML, repo: OrdinaryDiffEq.jl, group: Interface}
           - {user: SciML, repo: DelayDiffEq.jl, group: Interface}
-          - {user: JuliaSIMD, repo: VectorizationBase.jl, group: Interface}
-          - {user: JuliaSIMD, repo: LoopVectorization.jl, group: Downstream3}
+
     steps:
       - uses: actions/checkout@v2
       - uses: julia-actions/setup-julia@v1
@@ -45,18 +44,14 @@ jobs:
           repository: ${{ matrix.package.user }}/${{ matrix.package.repo }}
           path: downstream
       - name: Load this and run the downstream tests
-        shell: julia --color=yes {0}
+        shell: julia --color=yes --project=downstream {0}
         run: |
           using Pkg
           try
             # force it to use this PR's version of the package
             Pkg.develop(PackageSpec(path="."))  # resolver may fail with main deps
-            Pkg.develop(Pkg.PackageSpec(path=joinpath(pwd(), "lib", "ArrayInterfaceCore")))
-            Pkg.develop(Pkg.PackageSpec(path=joinpath(pwd(), "lib", "ArrayInterfaceOffsetArrays")))
-            Pkg.develop(Pkg.PackageSpec(path=joinpath(pwd(), "lib", "ArrayInterfaceStaticArrays")))
-            Pkg.activate("downstream")
             Pkg.update()
-            Pkg.test()  # resolver may fail with test time deps
+            Pkg.test(coverage=true)  # resolver may fail with test time deps
           catch err
             err isa Pkg.Resolve.ResolverError || rethrow()
             # If we can't resolve that means this is incompatible by SemVer and this is fine
@@ -65,3 +60,7 @@ jobs:
             @info "Not compatible with this release. No problem." exception=err
             exit(0)  # Exit immediately, as a success
           end
+      - uses: julia-actions/julia-processcoverage@v1
+      - uses: codecov/codecov-action@v1
+        with:
+          file: lcov.info

docs/src/index.md

@@ -27,47 +27,47 @@ to the interface, and is likely to be deprecated in the near future as the compi
 ### Traits
 
 ```@docs
-ArrayInterfaceCore.can_avx
-ArrayInterfaceCore.can_change_size
-ArrayInterfaceCore.can_setindex
-ArrayInterfaceCore.device
-ArrayInterfaceCore.defines_strides
-ArrayInterfaceCore.fast_matrix_colors
-ArrayInterfaceCore.fast_scalar_indexing
-ArrayInterfaceCore.indices_do_not_alias
-ArrayInterfaceCore.instances_do_not_alias
-ArrayInterfaceCore.is_forwarding_wrapper
-ArrayInterfaceCore.ismutable
-ArrayInterfaceCore.isstructured
-ArrayInterfaceCore.has_sparsestruct
-ArrayInterfaceCore.ndims_index
-ArrayInterfaceCore.ndims_shape
+ArrayInterface.can_avx
+ArrayInterface.can_change_size
+ArrayInterface.can_setindex
+ArrayInterface.device
+ArrayInterface.defines_strides
+ArrayInterface.fast_matrix_colors
+ArrayInterface.fast_scalar_indexing
+ArrayInterface.indices_do_not_alias
+ArrayInterface.instances_do_not_alias
+ArrayInterface.is_forwarding_wrapper
+ArrayInterface.ismutable
+ArrayInterface.isstructured
+ArrayInterface.has_sparsestruct
+ArrayInterface.ndims_index
+ArrayInterface.ndims_shape
 
 ```
 
 ### Functions
 
 ```@docs
-ArrayInterfaceCore.allowed_getindex
-ArrayInterfaceCore.allowed_setindex!
-ArrayInterfaceCore.aos_to_soa
-ArrayInterfaceCore.buffer
-ArrayInterfaceCore.findstructralnz
-ArrayInterfaceCore.lu_instance
-ArrayInterfaceCore.matrix_colors
-ArrayInterfaceCore.issingular
-ArrayInterfaceCore.parent_type
-ArrayInterfaceCore.promote_eltype
-ArrayInterfaceCore.restructure
-ArrayInterfaceCore.safevec
-ArrayInterfaceCore.zeromatrix
-ArrayInterfaceCore.undefmatrix
+ArrayInterface.allowed_getindex
+ArrayInterface.allowed_setindex!
+ArrayInterface.aos_to_soa
+ArrayInterface.buffer
+ArrayInterface.findstructralnz
+ArrayInterface.lu_instance
+ArrayInterface.matrix_colors
+ArrayInterface.issingular
+ArrayInterface.parent_type
+ArrayInterface.promote_eltype
+ArrayInterface.restructure
+ArrayInterface.safevec
+ArrayInterface.zeromatrix
+ArrayInterface.undefmatrix
 ```
 
 ### Types
 
 ```@docs
-ArrayInterfaceCore.ArrayIndex
-ArrayInterfaceCore.GetIndex
-ArrayInterfaceCore.SetIndex!
+ArrayInterface.ArrayIndex
+ArrayInterface.GetIndex
+ArrayInterface.SetIndex!
 ```

src/ArrayInterface.jl

@@ -688,8 +688,6 @@ Base.@propagate_inbounds function Base.getindex(ind::TridiagonalIndex, i::Int)
     end
 end
 
-_cartesian_index(i::Tuple{Vararg{Int}}) = CartesianIndex(i)
-_cartesian_index(::Any) = nothing
 
 """
     ndims_index(::Type{I}) -> Int
@@ -748,12 +746,7 @@ ndims_shape(@nospecialize T::Type{<:AbstractArray{Bool}}) = 1
 ndims_shape(@nospecialize T::Type{<:AbstractArray}) = ndims(T)
 ndims_shape(x) = ndims_shape(typeof(x))
 
-@assume_effects :total function _find_first_true(isi::Tuple{Vararg{Bool, N}}) where {N}
-    for i in 1:N
-        getfield(isi, i) && return i
-    end
-    return nothing
-end
+
 
 """
     instances_do_not_alias(::Type{T}) -> Bool

test/core.jl

@@ -1,7 +1,7 @@
 using ArrayInterface
 using ArrayInterface: zeromatrix, undefmatrix
 import ArrayInterface: has_sparsestruct, findstructralnz, fast_scalar_indexing, lu_instance,
-        parent_type, zeromatrix, IndicesInfo
+        parent_type, zeromatrix
 using LinearAlgebra
 using Random
 using SparseArrays