Relax Ultraspherical ConcreteConversion order types (#217)

* Relax Ultraspherical ConcreteConversion order types

* union of tuples in bandwidths

* Disable CI on Windows

Author: jishnub

.github/workflows/ci.yml

@@ -42,7 +42,7 @@ jobs:
         os:
           - ubuntu-latest
           - macOS-latest
-          - windows-latest
+          # - windows-latest
         arch:
           - x64
     steps:

Project.toml

@@ -1,6 +1,6 @@
 name = "ApproxFunOrthogonalPolynomials"
 uuid = "b70543e2-c0d9-56b8-a290-0d4d6d4de211"
-version = "0.6.18"
+version = "0.6.19"
 
 [deps]
 ApproxFunBase = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"

src/Spaces/Jacobi/Jacobi.jl

@@ -9,7 +9,7 @@ struct Jacobi{D<:Domain,R,T} <: PolynomialSpace{D,R}
     b::T
     a::T
     domain::D
-    Jacobi{D,R}(b::T,a::T,d::D) where {D,R,T} = new{D,R,T}(b,a,d)
+    Jacobi{D,R}(b::T,a::T,d::D) where {D,R,T<:Number} = new{D,R,T}(b,a,d)
 end
 Jacobi(b::T,a::T,d::Domain) where {T<:Number} =
     Jacobi{typeof(d),promote_type(T,real(prectype(d)))}(b, a, d)

src/Spaces/Ultraspherical/UltrasphericalOperators.jl

@@ -247,13 +247,19 @@ end
 bandwidths(C::ConcreteConversion{<:Chebyshev,<:Ultraspherical{<:Union{Integer,StaticInt}}}) = 0,2  # order == 1
 bandwidths(C::ConcreteConversion{<:Ultraspherical{<:Union{Integer,StaticInt}},<:Ultraspherical{<:Union{Integer,StaticInt}}}) = 0,2
 
-bandwidths(C::ConcreteConversion{<:Chebyshev,<:Ultraspherical}) =
-    0,order(rangespace(C))==1 ? 2 : ℵ₀
-bandwidths(C::ConcreteConversion{<:Ultraspherical,<:Chebyshev}) =
-    0,order(domainspace(C))==1 ? 2 : ℵ₀
+function bandwidths(C::ConcreteConversion{<:Chebyshev,<:Ultraspherical})
+    orderone = order(rangespace(C)) == 1
+    orderone ? (0,2) : (0,ℵ₀)
+end
+function bandwidths(C::ConcreteConversion{<:Ultraspherical,<:Chebyshev})
+    orderone = order(domainspace(C)) == 1
+    orderone ? (0,2) : (0,ℵ₀)
+end
 
-bandwidths(C::ConcreteConversion{<:Ultraspherical,<:Ultraspherical}) =
-    0,order(domainspace(C))+1==order(rangespace(C)) ? 2 : ℵ₀
+function bandwidths(C::ConcreteConversion{<:Ultraspherical,<:Ultraspherical})
+    offbyone = order(domainspace(C))+1 == order(rangespace(C))
+    offbyone ? (0,2) : (0,ℵ₀)
+end
 
 Base.stride(C::ConcreteConversion{<:Chebyshev,<:Ultraspherical{<:Union{Integer,StaticInt}}}) = 2
 Base.stride(C::ConcreteConversion{<:Ultraspherical,<:Ultraspherical}) = 2

src/fastops.jl

@@ -10,8 +10,9 @@
 # Conversions
 #####
 
-function BandedMatrix(S::SubOperator{T,ConcreteConversion{Chebyshev{DD,RR},Ultraspherical{Int,DD,RR},T},
-                              NTuple{2,UnitRange{Int}}}) where {T,DD,RR}
+function BandedMatrix(S::SubOperator{T,ConcreteConversion{Chebyshev{DD,RR},
+                Ultraspherical{LT,DD,RR},T},
+            NTuple{2,UnitRange{Int}}}) where {T,LT<:Union{Integer, StaticInt},DD,RR}
     # we can assume order is 1
     ret = BandedMatrix{eltype(S)}(undef, size(S), bandwidths(S))
     kr,jr = parentindices(S)
@@ -31,8 +32,8 @@ function BandedMatrix(S::SubOperator{T,ConcreteConversion{Chebyshev{DD,RR},Ultra
     ret
 end
 
-function BandedMatrix(V::SubOperator{T,ConcreteConversion{Ultraspherical{LT,DD,RR},Ultraspherical{LT,DD,RR},T},
-                                                                  NTuple{2,UnitRange{Int}}}) where {T,LT,DD,RR}
+function BandedMatrix(V::SubOperator{T,ConcreteConversion{Ultraspherical{LT1,DD,RR},Ultraspherical{LT2,DD,RR},T},
+                                                                  NTuple{2,UnitRange{Int}}}) where {T,LT1,LT2,DD,RR}
 
     n,m = size(V)
     V_l, V_u = bandwidths(V)