maxspace_rule/conversion_rule for normalized returns parent (#258)

* maxspace_rule/conversion_rule for normalized returns parent

* Test for conversion_type with interval

* simplify implementation

Author: jishnub

Project.toml

@@ -1,6 +1,6 @@
 name = "ApproxFunOrthogonalPolynomials"
 uuid = "b70543e2-c0d9-56b8-a290-0d4d6d4de211"
-version = "0.6.31"
+version = "0.6.32"
 
 [deps]
 ApproxFunBase = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"
@@ -22,7 +22,7 @@ StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
 Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
 
 [compat]
-ApproxFunBase = "0.8.28"
+ApproxFunBase = "0.8.30"
 ApproxFunBaseTest = "0.1"
 Aqua = "0.6"
 BandedMatrices = "0.16, 0.17"

src/Spaces/PolynomialSpace.jl

@@ -476,13 +476,11 @@ function Fun(::typeof(identity), S::NormalizedPolynomialSpace)
 end
 
 function conversion_rule(a::NormalizedPolynomialSpace{S}, b::S) where S<:PolynomialSpace
-    asp = a.space
-    c = conversion_type(asp, b)
-    if c == asp
-        return a
-    else
-        return c
-    end
+    conversion_type(a.space, b)
+end
+
+function maxspace_rule(a::NormalizedPolynomialSpace{S}, b::S) where S<:PolynomialSpace
+    maxspace(a.space, b)
 end
 
 bandwidths(C::ConcreteConversion{NormalizedPolynomialSpace{S,D,R},S}) where {S,D,R} = (0, 0)

test/JacobiTest.jl

@@ -210,10 +210,13 @@ include("testutils.jl")
             end
 
             @testset "conversion_type for NormalizedPolynomialSpace" begin
-                @test conversion_type(NormalizedLegendre(), Jacobi(1,1)) == NormalizedLegendre()
-                @test conversion_type(Jacobi(1,1), NormalizedLegendre()) == NormalizedLegendre()
-                @test conversion_type(Jacobi(1,1), NormalizedJacobi(2,2)) == Jacobi(1,1)
-                @test conversion_type(NormalizedJacobi(2,2), Jacobi(1,1)) == Jacobi(1,1)
+                @test (@inferred conversion_type(NormalizedLegendre(), Jacobi(1,1))) == Legendre()
+                @test (@inferred conversion_type(Jacobi(1,1), NormalizedLegendre())) == Legendre()
+                @test (@inferred conversion_type(Jacobi(1,1), NormalizedJacobi(2,2))) == Jacobi(1,1)
+                @test (@inferred conversion_type(NormalizedJacobi(2,2), Jacobi(1,1))) == Jacobi(1,1)
+
+                @test (@inferred (() ->
+                    conversion_type(NormalizedLegendre(0..1), Legendre(0..1)))()) == Legendre(0..1)
             end
 
             @testset "NormalizedPolynomialSpace constructor" begin
@@ -636,6 +639,11 @@ include("testutils.jl")
             @test space(1 + Fun(NormalizedLegendre())) == NormalizedLegendre()
             @test space(1 + Fun(NormalizedJacobi(1,1,0..1))) == NormalizedJacobi(1,1,0..1)
         end
+
+        @testset "inference in maxspace/conversion_type" begin
+            @inferred maxspace(NormalizedLegendre(), Legendre())
+            @inferred (()->maxspace(NormalizedLegendre(0..1), Legendre(0..1)))()
+        end
     end
 
     @testset "casting bug ApproxFun.jl#770" begin